Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hue] scan with multiple bridges removes items during scan again #7451

Closed
Marlow925 opened this issue Apr 22, 2020 · 1 comment · Fixed by #7461
Closed

[hue] scan with multiple bridges removes items during scan again #7451

Marlow925 opened this issue Apr 22, 2020 · 1 comment · Fixed by #7461
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@Marlow925
Copy link

Marlow925 commented Apr 22, 2020 •
edited
Loading

In a scenario with multiple Philips Hue Hubs (due to the recommended limitation of max 50 lights per hub), the following is happening:

  • when OpenHAB is started fresh, it will scan through all the hubs and discover all the items, that are not defined in things and add these to the inbox.

  • if you subsequently rescan the Hue Binding in the inbox, it will discover these items again, but then remove them, as it scans the next hub. Only the items from whatever hub is scanned last will remain in the inbox.

As a result, one has to know, what one wants to add and has to be quick to add these before the scan gets to the next hub. Or completely restart OpenHAB, which is a bit meh.

I am currently running OpenHAB 2.5.4 on Ubuntu 14.04.6 LTS on an ODroid board and that behavior is still present there.
@Marlow925 Marlow925 added the bug An unexpected problem or unintended behavior of an add-on label Apr 22, 2020
@lolodomo
Copy link
Contributor

lolodomo commented Apr 24, 2020 •
edited
Loading

Ithink this is due to this line:
https://github.com/openhab/openhab-addons/blob/2.5.x/bundles/org.openhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/discovery/HueLightDiscoveryService.java#L140

removeOlderResults should be called with the bridge id as second parameter.

lolodomo added a commit to lolodomo/openhab-addons that referenced this issue Apr 24, 2020
@lolodomo
[hue] Remove older discovery results from the current bridge only
af7f0ed 
Fix openhab#7451

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo mentioned this issue Apr 24, 2020
Merged
cpmeister pushed a commit that referenced this issue Apr 24, 2020
@lolodomo
[hue] Remove older discovery results from the current bridge only (#7461
46e11b6 
)

Fix #7451

Signed-off-by: Laurent Garnier <[email protected]>
yfre pushed a commit to yfre/openhab-addons that referenced this issue Apr 27, 2020
@lolodomo
[hue] Remove older discovery results from the current bridge only (op…
bf4e519 
…enhab#7461)

Fix openhab#7451

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this issue Jun 8, 2020
@lolodomo @LoungeFlyZ
[hue] Remove older discovery results from the current bridge only (op…
3ffd47a 
…enhab#7461)

Fix openhab#7451

Signed-off-by: Laurent Garnier <[email protected]>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this issue Jul 14, 2020
@lolodomo @J-N-K
[hue] Remove older discovery results from the current bridge only (op…
123b1fa 
…enhab#7461)

Fix openhab#7451

Signed-off-by: Laurent Garnier <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this issue Jul 26, 2020
@lolodomo @CSchlipp
[hue] Remove older discovery results from the current bridge only (op…
5aa1ab8 
…enhab#7461)

Fix openhab#7451

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@lolodomo @andrewfg
[hue] Remove older discovery results from the current bridge only (op…
30bb538 
…enhab#7461)

Fix openhab#7451

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@lolodomo @andrewfg
[hue] Remove older discovery results from the current bridge only (op…
92f33bd 
…enhab#7461)

Fix openhab#7451

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@lolodomo @andrewfg
[hue] Remove older discovery results from the current bridge only (op…
fc7c691 
…enhab#7461)

Fix openhab#7451

Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@lolodomo @andrewfg
[hue] Remove older discovery results from the current bridge only (op…
329ecd1 
…enhab#7461)

Fix openhab#7451

Signed-off-by: Laurent Garnier <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this issue Sep 1, 2020
@lolodomo @DaanMeijer
[hue] Remove older discovery results from the current bridge only (op…
f3bcd49 
…enhab#7461)

Fix openhab#7451

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this issue Sep 19, 2020
@lolodomo @markus7017
[hue] Remove older discovery results from the current bridge only (op…
29d7861 
…enhab#7461)

Fix openhab#7451

Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[hue] Remove older discovery results from the current bridge only lolodomo/openhab-addons
2 participants
@lolodomo @Marlow925