Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[astro] Update Astro binding to use local country data for calculating seasons #5732

Closed
lukiep opened this issue Jun 15, 2019 · 3 comments · Fixed by #7876
Closed

[astro] Update Astro binding to use local country data for calculating seasons #5732

lukiep opened this issue Jun 15, 2019 · 3 comments · Fixed by #7876
Labels
enhancement An enhancement or new feature for an existing add-on PR pending There is a pull request for resolving the issue

Comments

@lukiep
Copy link

lukiep commented Jun 15, 2019

Your Environment

  • Version used: OpenHAB 2.4 stable
  • Environment name and version (e.g. Chrome 39, node.js 5.4, Java 8, ...):
  • Operating System and version (desktop or mobile, Windows 10, Raspbian Jessie, ...): openHABian v1.4.1-468

Apparently season start and end dates are not consistently applied between countries. Some countries commence their seasons on the equinox or solstice (which may be the current Astro binding behaviour) however this differs between countries. In Australia the following is true:
Spring starts 1st September
Summer starts 1st December
Autumn starts 1st March
Winter starts 1st June

Potential solutions include using location data to set the correct season behaviour or (if this is too complex due to the huge variance in how seasons are recorded) alternatively allow the user to set it themselves in the binding. I'm sure there are other options also.

Associated links:
eclipse-archived/smarthome#4767 (comment)
https://community.openhab.org/t/oh2-astro-binding-feature-request-seasons-in-australia/37367/4
@lukiep lukiep changed the title [astro][feature] [astro][feature] Update Astro binding to use local country data for calculating seasons Jun 15, 2019
@wborn wborn added the enhancement An enhancement or new feature for an existing add-on label Jun 18, 2019
@wborn wborn changed the title [astro][feature] Update Astro binding to use local country data for calculating seasons [astro] Update Astro binding to use local country data for calculating seasons Jun 18, 2019
@idkpmiller
Copy link

New Zealand also uses the same dates as Australia. And I would support the ability to specify dates chosen locally rather than ones calculated through astro entitys. Nether seem to be 100% accurate as nature is not predictable to such a degree. So neither method can be consider right or wrong but we should accommodate both.

Regards
Paul

@cods69
Copy link

cods69 commented Jun 7, 2020

I would be happy for two items to come out of this change, one solar based as it is now, as well as calendar based season. That would be the ideal scenario.

clinique added a commit to clinique/openhab-addons that referenced this issue Jun 8, 2020
@clinique
Adressing issue openhab#5732
02506d1 
Signed-off-by: clinique <[email protected]>
@clinique
Copy link
Contributor

clinique commented Jun 8, 2020

This PR follows discussion initiated with @Hilbrand in this topic

@clinique clinique mentioned this issue Jun 9, 2020
Merged
@cweitkamp cweitkamp added the PR pending There is a pull request for resolving the issue label Jun 9, 2020
clinique added a commit to clinique/openhab-addons that referenced this issue Jun 10, 2020
@clinique
Adressing issue openhab#5732
09e766e 
Signed-off-by: clinique <[email protected]>
clinique added a commit to clinique/openhab-addons that referenced this issue Jun 10, 2020
@clinique
Adressing issue openhab#5732
0a746b0 
solving Conflicts:
	bundles/org.openhab.binding.astro/src/main/java/org/openhab/binding/astro/internal/config/AstroThingConfig.java

Signed-off-by: clinique <[email protected]>
clinique added a commit to clinique/openhab-addons that referenced this issue Jun 11, 2020
@clinique
Adressing issue openhab#5732
68cab2a 
Signed-off-by: clinique <[email protected]>
clinique added a commit to clinique/openhab-addons that referenced this issue Jun 11, 2020
@clinique
Adressing issue openhab#5732
ef66149 
solving Conflicts:
	bundles/org.openhab.binding.astro/src/main/java/org/openhab/binding/astro/internal/config/AstroThingConfig.java

Signed-off-by: clinique <[email protected]>
clinique added a commit to clinique/openhab-addons that referenced this issue Jun 11, 2020
@clinique
Adressing issue openhab#5732
d0e0bf4 
Rebasing on last modifications
solving Conflicts:
	bundles/org.openhab.binding.astro/src/main/java/org/openhab/binding/astro/internal/config/AstroThingConfig.java

Conflicts:
	bundles/org.openhab.binding.astro/src/main/java/org/openhab/binding/astro/internal/discovery/AstroDiscoveryService.java

Signed-off-by: clinique <[email protected]>
clinique added a commit to clinique/openhab-addons that referenced this issue Jun 12, 2020
@clinique
Adressing issue openhab#5732
ff6ec6d 
Fixing integration test and adding some non null by default

Signed-off-by: Gaël L'hopital <[email protected]>
J-N-K pushed a commit that referenced this issue Jun 12, 2020
@clinique
[astro] add localized seasons (#7876)
6ab53e1 
Closes #5732 

Signed-off-by: Gaël L'hopital <[email protected]>
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this issue Jul 12, 2020
@clinique @knikhilwiz
[astro] add localized seasons (openhab#7876)
088052e 
Closes openhab#5732 

Signed-off-by: Gaël L'hopital <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this issue Jul 26, 2020
@clinique @CSchlipp
[astro] add localized seasons (openhab#7876)
2cecb72 
Closes openhab#5732 

Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@clinique @andrewfg
[astro] add localized seasons (openhab#7876)
ce2a6b2 
Closes openhab#5732 

Signed-off-by: Gaël L'hopital <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@clinique @andrewfg
[astro] add localized seasons (openhab#7876)
62e50ff 
Closes openhab#5732 

Signed-off-by: Gaël L'hopital <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@clinique @andrewfg
[astro] add localized seasons (openhab#7876)
2fd1328 
Closes openhab#5732 

Signed-off-by: Gaël L'hopital <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this issue Aug 31, 2020
@clinique @andrewfg
[astro] add localized seasons (openhab#7876)
0b2bd77 
Closes openhab#5732 

Signed-off-by: Gaël L'hopital <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this issue Sep 1, 2020
@clinique @DaanMeijer
[astro] add localized seasons (openhab#7876)
1c52b88 
Closes openhab#5732 

Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this issue Sep 19, 2020
@clinique @markus7017
[astro] add localized seasons (openhab#7876)
d2e7399 
Closes openhab#5732 

Signed-off-by: Gaël L'hopital <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on PR pending There is a pull request for resolving the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[astro] Adressing issue #5732 clinique/openhab-addons
6 participants
@idkpmiller @clinique @cweitkamp @wborn @lukiep @cods69