Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deconz] Fails tests. Breaks CI build #17104

Closed
andrewfg opened this issue Jul 19, 2024 · 8 comments · Fixed by #17108
Closed

[deconz] Fails tests. Breaks CI build #17104

andrewfg opened this issue Jul 19, 2024 · 8 comments · Fixed by #17108
Assignees
@andrewfg
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@andrewfg
Copy link
Contributor

andrewfg commented Jul 19, 2024 •
edited
Loading

The deconz binding is failing tests during the CI build process, thus killing the whole addons build process.
@andrewfg andrewfg added the bug An unexpected problem or unintended behavior of an add-on label Jul 19, 2024
@J-N-K
Copy link
Member

J-N-K commented Jul 19, 2024

Please link a failed build.

@andrewfg
Copy link
Contributor Author

^
https://github.com/openhab/openhab-addons/actions/runs/10006865459/job/27660397782?pr=17099

@andrewfg
Copy link
Contributor Author

I wonder if the Junit tests in #17099 are somehow affecting the state of the (following) Junit tests in deconz? It is hard to imagine why or how that could be..

@J-N-K
Copy link
Member

J-N-K commented Jul 19, 2024

I don't think this is an issue with the deconz tests, because they succeed in Jenkins. It's more likely an issue with the GitHub build configuration. I also don't see which test fails, because the log doesn't contain that information.

@andrewfg
Copy link
Contributor Author

It also fails on a local Maven build. Tomorrow I will run that again, and post the log.

@andrewfg
Copy link
Contributor Author

@J-N-K below is the log from a local Maven build attempt..

[INFO] Running org.openhab.binding.deconz.internal.handler.SensorThermostatThingHandlerTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.415 s -- in org.openhab.binding.deconz.internal.handler.SensorThermostatThingHandlerTest
[INFO] Running org.openhab.binding.deconz.internal.handler.SensorThingHandlerTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.086 s -- in org.openhab.binding.deconz.internal.handler.SensorThingHandlerTest
[INFO] Running org.openhab.binding.deconz.LightGroupTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.039 s -- in org.openhab.binding.deconz.LightGroupTest
[INFO] Running org.openhab.binding.deconz.LightsTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.063 s -- in org.openhab.binding.deconz.LightsTest
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   DeconzTest.discoveryTest:99
discoveryListener.thingDiscovered(
    <any>,
    <any>
);
Wanted 20 times:
-> at org.openhab.binding.deconz.DeconzTest.discoveryTest(DeconzTest.java:99)
But was 40 times:
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)
-> at org.openhab.core.config.discovery.AbstractDiscoveryService.thingDiscovered(AbstractDiscoveryService.java:256)


[INFO]
[ERROR] Tests run: 18, Failures: 1, Errors: 0, Skipped: 0

@J-N-K
Copy link
Member

J-N-K commented Jul 19, 2024

It's probably a result of openhab/openhab-core#4323

@andrewfg
Copy link
Contributor Author

^ probably a result of openhab/openhab-core#4323

@lolodomo ping!

andrewfg added a commit to andrewfg/openhab-addons that referenced this issue Jul 20, 2024
@andrewfg
[deconz] Fix tests. Fix openhab#17104
1babd20 
Signed-off-by: AndrewFG <[email protected]>
@andrewfg andrewfg mentioned this issue Jul 20, 2024
Merged
@andrewfg andrewfg self-assigned this Jul 20, 2024
J-N-K pushed a commit that referenced this issue Jul 20, 2024
@andrewfg
[deconz] Fix tests. Fix #17104 (#17108)
5fdb9fd 
Signed-off-by: AndrewFG <[email protected]>
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this issue Aug 29, 2024
@andrewfg @digitaldan
[deconz] Fix tests. Fix openhab#17104 (openhab#17108)
73597dc 
Signed-off-by: AndrewFG <[email protected]>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this issue Sep 29, 2024
@andrewfg @pgfeller
[deconz] Fix tests. Fix openhab#17104 (openhab#17108)
e2722ca 
Signed-off-by: AndrewFG <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this issue Oct 15, 2024
@andrewfg @joni1993
[deconz] Fix tests. Fix openhab#17104 (openhab#17108)
d28045b 
Signed-off-by: AndrewFG <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this issue Oct 18, 2024
@andrewfg @matchews
[deconz] Fix tests. Fix openhab#17104 (openhab#17108)
78ea86a 
Signed-off-by: AndrewFG <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this issue Jan 2, 2025
@andrewfg
[deconz] Fix tests. Fix openhab#17104 (openhab#17108)
7c90358 
Signed-off-by: AndrewFG <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewfg andrewfg

Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[deconz] Fix tests. Fix #17104 andrewfg/openhab-addons
2 participants
@andrewfg @J-N-K