[jsscripting] Globals cannot be injected automatically on Windows

[ghys]

The JSScripting add-on doesn't seem to load the global variables (the default behavior) for UI-created rules on Windows.
Note that this seems to happen even when the Use Built-in Global Variables option in Settings > Other Services > JS Scripting is set to Do Not Use Built-in Variables.

On the same snapshot on Linux, it seems to work.

Expected Behavior

The global variables should be loaded with no exception.

Current Behavior

This exception appears in the logs on the first execution of a script, regardless of the option above:

[ERROR] [g.internal.OpenhabGraalJSScriptEngine] - Could not inject global script
javax.script.ScriptException: org.graalvm.polyglot.PolyglotException: TypeError: Cannot load CommonJS module: '@jsscripting-globals'
        at com.oracle.truffle.js.scriptengine.GraalJSScriptEngine.toScriptException(GraalJSScriptEngine.java:483) ~[?:?]
        at com.oracle.truffle.js.scriptengine.GraalJSScriptEngine.eval(GraalJSScriptEngine.java:460) ~[?:?]
        at com.oracle.truffle.js.scriptengine.GraalJSScriptEngine.eval(GraalJSScriptEngine.java:426) ~[?:?]
        at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:264) ~[java.scripting:?]
<snip>
Caused by: org.graalvm.polyglot.PolyglotException: TypeError: Cannot load CommonJS module: '@jsscripting-globals'
        at com.oracle.truffle.polyglot.PolyglotMapAndFunction.apply(PolyglotMapAndFunction.java:46) ~[?:?]
        at org.openhab.automation.jsscripting.internal.OpenhabGraalJSScriptEngine.lambda$3(OpenhabGraalJSScriptEngine.java:178) ~[?:?]
        at java.util.Optional.orElseGet(Optional.java:369) ~[?:?]
        at org.openhab.automation.jsscripting.internal.OpenhabGraalJSScriptEngine.lambda$1(OpenhabGraalJSScriptEngine.java:178) ~[?:?]
        at <js>.:program(<eval>:1) ~[?:?]
        at org.graalvm.polyglot.Context.eval(Context.java:379) ~[?:?]
        at com.oracle.truffle.js.scriptengine.GraalJSScriptEngine.eval(GraalJSScriptEngine.java:458) ~[?:?]
        ... 71 more

Possible Solution

A workaround is to add explitely:

var runtime = require('@runtime');

to all scripts and use that, this works, but the exception is ugly and cannot be avoided.

Steps to Reproduce (for Bugs)

1. Install the JSScripting add-on
2. Create a ECMAScript 2021 script in the UI (Settings > Scripts) or a rule with a script action set to ECMAScript 2021.
3. Run it

This might be because of path separators, for example here:

openhab-addons/bundles/org.openhab.automation.jsscripting/src/main/java/org/openhab/automation/jsscripting/internal/OpenhabGraalJSScriptEngine.java

Line 68 in a6cb90f

private static final Path LOCAL_NODE_PATH = Paths.get("/node_modules");

Context

The JSScripting add-on which is a big feature of openHAB 3.2 doesn't work well in the simplest scenario on Windows (e.g. for testing purposes).

Your Environment

On Windows, Zulu 11, fresh openHAB 3.2.0-SNAPSHOT - Build 2632,

[digitaldan]

oof, i'll get a fix in asap for that