Skip to content

Commit

Permalink
Review comments considered
Browse files Browse the repository at this point in the history 
Signed-off-by: Laurent Garnier <[email protected]>
  • Loading branch information
@lolodomo
lolodomo committed May 2, 2020
1 parent 76c7df3 commit f30043f
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 15 deletions.
22 changes: 11 additions & 11 deletions ....binding.hue/src/main/java/org/openhab/binding/hue/internal/handler/HueBridgeHandler.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ protected void doConnectedRun() throws IOException, ApiException {
try {
sensorStatusListener.onSensorRemoved(hueBridge, fullSensorEntry.getValue());
} catch (Exception e) {
logger.error("An exception occurred while calling the Sensor Listeners", e);
logger.debug("An exception occurred while calling the Sensor Listeners", e);
}
}
}
Expand Down Expand Up @@ -252,7 +252,7 @@ protected void doConnectedRun() throws IOException, ApiException {
try {
lightStatusListener.onLightRemoved(hueBridge, fullLightEntry.getValue());
} catch (Exception e) {
logger.error("An exception occurred while calling the BridgeHeartbeatListener", e);
logger.debug("An exception occurred while calling the BridgeHeartbeatListener", e);
}
}
}
Expand Down Expand Up @@ -328,7 +328,7 @@ protected void doConnectedRun() throws IOException, ApiException {
try {
groupStatusListener.onGroupRemoved(hueBridge, fullGroupEntry.getValue());
} catch (Exception e) {
logger.error("An exception occurred while calling the Group Listeners", e);
logger.debug("An exception occurred while calling the Group Listeners", e);
}
}
}
Expand Down Expand Up @@ -358,7 +358,7 @@ public void updateLightState(FullLight light, StateUpdate stateUpdate) {
return null;
});
} else {
logger.warn("No bridge connected or selected. Cannot set light state.");
logger.debug("No bridge connected or selected. Cannot set light state.");
}
}

Expand All @@ -376,7 +376,7 @@ public void updateSensorState(FullSensor sensor, StateUpdate stateUpdate) {
return null;
});
} else {
logger.warn("No bridge connected or selected. Cannot set sensor state.");
logger.debug("No bridge connected or selected. Cannot set sensor state.");
}
}

Expand All @@ -394,7 +394,7 @@ public void updateSensorConfig(FullSensor sensor, ConfigUpdate configUpdate) {
return null;
});
} else {
logger.warn("No bridge connected or selected. Cannot set sensor config.");
logger.debug("No bridge connected or selected. Cannot set sensor config.");
}
}

Expand All @@ -407,7 +407,7 @@ public void updateGroupState(FullGroup group, StateUpdate stateUpdate) {
handleStateUpdateException(group, stateUpdate, e);
}
} else {
logger.warn("No bridge connected or selected. Cannot set group state.");
logger.debug("No bridge connected or selected. Cannot set group state.");
}
}

Expand Down Expand Up @@ -838,7 +838,7 @@ private <T> T withReAuthentication(String taskDescription, Callable<T> runnable)
}
}
} catch (Exception e) {
logger.error("Bridge cannot {}.", taskDescription, e);
logger.debug("Bridge cannot {}.", taskDescription, e);
}
}
return null;
Expand Down Expand Up @@ -875,7 +875,7 @@ private void notifyLightStatusListeners(final FullLight fullLight, final String
"Could not notify lightStatusListeners for unknown event type " + type);
}
} catch (Exception e) {
logger.error("An exception occurred while calling the BridgeHeartbeatListener", e);
logger.debug("An exception occurred while calling the BridgeHeartbeatListener", e);
}
}
}
Expand Down Expand Up @@ -905,7 +905,7 @@ private void notifySensorStatusListeners(final FullSensor fullSensor, final Stri
"Could not notify sensorStatusListeners for unknown event type " + type);
}
} catch (Exception e) {
logger.error("An exception occurred while calling the Sensor Listeners", e);
logger.debug("An exception occurred while calling the Sensor Listeners", e);
}
}
}
Expand Down Expand Up @@ -935,7 +935,7 @@ private void notifyGroupStatusListeners(final FullGroup fullGroup, final String
"Could not notify groupStatusListeners for unknown event type " + type);
}
} catch (Exception e) {
logger.error("An exception occurred while calling the Group Listeners", e);
logger.debug("An exception occurred while calling the Group Listeners", e);
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions ...b.binding.hue/src/main/java/org/openhab/binding/hue/internal/handler/HueGroupHandler.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ public void handleCommand(ChannelUID channelUID, Command command) {
public void handleCommand(String channel, Command command, long fadeTime) {
HueClient bridgeHandler = getHueClient();
if (bridgeHandler == null) {
logger.warn("hue bridge handler not found. Cannot handle command without bridge.");
logger.debug("hue bridge handler not found. Cannot handle command without bridge.");
return;
}

Expand Down Expand Up @@ -239,7 +239,7 @@ public void handleCommand(String channel, Command command, long fadeTime) {
}
bridgeHandler.updateGroupState(group, groupState);
} else {
logger.warn("Command sent to an unknown channel id: {}:{}", getThing().getUID(), channel);
logger.debug("Command sent to an unknown channel id: {}:{}", getThing().getUID(), channel);
}
}

Expand Down
4 changes: 2 additions & 2 deletions bundles/org.openhab.binding.hue/src/main/resources/ESH-INF/thing/Group.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@
<description>The group identifier identifies one certain hue group or room.</description>
<required>true</required>
</parameter>
<parameter name="fadetime" type="integer" min="0" step="100">
<parameter name="fadetime" type="integer" min="0" step="100" unit="ms">
<label>Fade Time</label>
<description>Fade time in ms for changing values</description>
<description>Fade time for changing values</description>
<default>400</default>
</parameter>
</config-description>
Expand Down

0 comments on commit f30043f

Please sign in to comment.