[hpprinter]: fix NPE in discovery (#8364)

Signed-off-by: Stefan Roellin <[email protected]>
openhab · Aug 30, 2020 · 981698a · 981698a
1 parent a8116c8
commit 981698a
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/...r/src/main/java/org/openhab/binding/hpprinter/internal/HPPrinterDiscoveryParticipant.java b/...r/src/main/java/org/openhab/binding/hpprinter/internal/HPPrinterDiscoveryParticipant.java
@@ -12,7 +12,7 @@
  */
 package org.openhab.binding.hpprinter.internal;
 
-import static org.openhab.binding.hpprinter.internal.HPPrinterBindingConstants.*;
+import static org.openhab.binding.hpprinter.internal.HPPrinterBindingConstants.THING_PRINTER;
 
 import java.net.InetAddress;
 import java.util.HashMap;
@@ -52,13 +52,14 @@ public class HPPrinterDiscoveryParticipant implements MDNSDiscoveryParticipant {
         }
 
         // We only care about HP Printers
-        if (service.getPropertyString("ty").toLowerCase().startsWith("hp")) {
+        String ty = service.getPropertyString("ty");
+        if (ty != null && ty.toLowerCase().startsWith("hp")) {
             String rp = service.getPropertyString("rp");
             if (rp == null) {
                 return null;
             }
 
-            logger.debug("Found HP Printer ID: {}", service.getPropertyString("ty"));
+            logger.debug("Found HP Printer ID: {}", ty);
             ThingUID uid = getThingUID(service);
             if (uid != null) {
                 Map<String, Object> properties = new HashMap<>(2);
@@ -76,10 +77,10 @@ public class HPPrinterDiscoveryParticipant implements MDNSDiscoveryParticipant {
                         label);
                 return result;
             } else {
-                logger.debug("Found unsupported HP Printer ID: {}", service.getPropertyString("ty"));
+                logger.debug("Found unsupported HP Printer ID: {}", ty);
             }
         } else {
-            logger.trace("Ignore non HP device {}", service.getPropertyString("ty"));
+            logger.trace("Ignore non HP device {}", ty);
         }
 
         return null;