Remove stacktrace print and reduce logging severity level #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sami Salonen <[email protected]>
Most error and warn level logs are logged in transport bundle, no need to log them here. Signed-off-by: Sami Salonen <[email protected]>
ssalonen
changed the title
kaikreuzer
approved these changes
Jun 28, 2020
|
Thanks @ssalonen - I have just published a new release of the lib to bintray: https://bintray.com/openhab/mvn/jamod/1.2.4.OH |
|
Thanks! Will it end up in openHAB 2/3 release at some point? |
|
I would say it will end up there once you create a PR, which changes this line: https://github.com/openhab/openhab-addons/blob/2.5.x/bundles/org.openhab.io.transport.modbus/pom.xml#L30 |
ssalonen
added a commit
to ssalonen/openhab2-addons
that referenced
this pull request
Jul 4, 2020
See openhab/jamod#4 Signed-off-by: Sami Salonen <[email protected]>
kaikreuzer
pushed a commit
to openhab/openhab-addons
that referenced
this pull request
Jul 4, 2020
See openhab/jamod#4 Signed-off-by: Sami Salonen <[email protected]>
knikhilwiz
pushed a commit
to knikhilwiz/openhab2-addons
that referenced
this pull request
Jul 12, 2020
See openhab/jamod#4 Signed-off-by: Sami Salonen <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
See openhab/jamod#4 Signed-off-by: Sami Salonen <[email protected]> Signed-off-by: CSchlipp <[email protected]>
MPH80
pushed a commit
to MPH80/openhab-addons
that referenced
this pull request
Aug 3, 2020
See openhab/jamod#4 Signed-off-by: Sami Salonen <[email protected]> Signed-off-by: MPH80 <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
See openhab/jamod#4 Signed-off-by: Sami Salonen <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
See openhab/jamod#4 Signed-off-by: Sami Salonen <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
See openhab/jamod#4 Signed-off-by: Sami Salonen <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
See openhab/jamod#4 Signed-off-by: Sami Salonen <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
See openhab/jamod#4 Signed-off-by: Sami Salonen <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
See openhab/jamod#4 Signed-off-by: Sami Salonen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection and I/O errors were printed out to stdout. Now removed to clean out the output.
Also many logging statements very tuned to be less loud, as the errors are handled in the transport bundle.
cc @kaikreuzer
I'm not sure how the release of this bundle really goes, hope you can execute the needed steps.
Signed-off-by: Sami Salonen [email protected]