Use self-executing anonymous function in osgi.js #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Rushworth <[email protected]>
lewie
reviewed
Jun 27, 2019
There was a problem hiding this comment.
As I have indicated here, this design pattern is a very clean solution. Personally, I always prefer it.
In particular it is not mandatory, because every loaded rule file in openHAB is assigned its own scope by Java and can work independently.
But I support the idea to propose this design pattern as a uniform standard in the documentation. If the complexity increases in the future, the community solutions will be cleanly separated from each other!
The individual community solutions don't know anything about each other and could easily interfere with each other without it. From this point of view it becomes even more important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lewie, it didn't look necessary, but I added this because it looked like a nice design pattern to follow for the JS libraries. I've used this in metadata.js too. WDYT?
Signed-off-by: Scott Rushworth [email protected]