Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ui bug #2236

Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix: ui bug #2236

merged 1 commit into from
Nov 23, 2023

Conversation

KishenKumarrrrr
Copy link
Contributor

Problem

e2e tests are failing because it relied on a subtitle that was part of the phonebook UI. Added it back here.

@KishenKumarrrrr KishenKumarrrrr self-assigned this Nov 23, 2023
@KishenKumarrrrr KishenKumarrrrr requested a review from jia1 November 23, 2023 01:27
jia1
jia1 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@jia1 jia1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU

@KishenKumarrrrr KishenKumarrrrr merged commit 66f2a56 into master Nov 23, 2023
6 checks passed
@KishenKumarrrrr KishenKumarrrrr deleted the fix/ui-bug branch November 23, 2023 01:35
@KishenKumarrrrr KishenKumarrrrr restored the fix/ui-bug branch November 23, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia1 jia1 jia1 approved these changes

Assignees

@KishenKumarrrrr KishenKumarrrrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KishenKumarrrrr @jia1