Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/remove phonebook #2235

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Refactor/remove phonebook #2235

merged 2 commits into from
Nov 23, 2023

Conversation

KishenKumarrrrr
Copy link
Contributor

Problem

Phonebook is shutting down 😢 . In this PR, I remove phonebook from postman.

Deployment Checklist

  • Remove unused env vars from AWS SM (can be done after deployment)

@KishenKumarrrrr KishenKumarrrrr self-assigned this Nov 16, 2023
@jia1
Copy link
Member

jia1 commented Nov 22, 2023

This method: const getPresignedUrl = async (): Promise<{ does not seem to be in use anymore. But I don't think it's essential to remove it either.

jia1
jia1 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@jia1 jia1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jia1 jia1 merged commit c5c3a1d into master Nov 23, 2023
30 of 31 checks passed
@jia1 jia1 deleted the refactor/remove-phonebook branch November 23, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia1 jia1 jia1 approved these changes

Assignees

@KishenKumarrrrr KishenKumarrrrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KishenKumarrrrr @jia1