Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update SGID scope and POCDEX profile field names #2233

Closed
wants to merge 1 commit into from

Conversation

KishenKumarrrrr
Copy link
Contributor

Problem

The SGID team made some breaking changes to the POCDEX login flow, as such in this PR, I have updated our BE and FE code to adhere to the newest changes.

Solution

  • POCDEX scope has changed from pocdex.public_officer_employments to pocdex.public_officer_details
  • The structure of data from the POCDEX scope has changed as well. The fields are now snake_case instead of camelCase

@KishenKumarrrrr KishenKumarrrrr self-assigned this Oct 20, 2023
@KishenKumarrrrr KishenKumarrrrr requested a review from jia1 October 20, 2023 06:28
@jia1
Copy link
Member

jia1 commented Oct 23, 2023

@KishenKumarrrrr is sgID broken now, despite us not changing the versions?

If so, that's rather unacceptable.

@jia1
Copy link
Member

jia1 commented Oct 23, 2023

Have asked Kishen. According to Kishen, the sgID team is maintaining both arrangements within the same client version. So we're good!

@KishenKumarrrrr
Copy link
Contributor Author

We no longer need to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants