Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(search): remove isSearchable, index conditions #914

Merged
merged 3 commits into from
Nov 18, 2020
Merged

refactor(search): remove isSearchable, index conditions #914

merged 3 commits into from
Nov 18, 2020

Conversation

LoneRifle
Copy link
Contributor

@LoneRifle LoneRifle commented Nov 16, 2020 •
edited
Loading

Problem

Given that GoSearch will be decommissioned, we have to backout its changes.
Start with removing references to isSearchable, and making the index unconditionally index the urls table.

Solution

  • Revert 4efddc9, and remove references to isSearchable in tests and sql fns
  • index shortUrl and desc unconditionally, and copy urlSearchVector into UrlRepository so that it is easier to
    remove models/search later on

@LoneRifle
Revert "feat(links): change Url table to have isSearchable field"
8a85879 
This reverts commit 4efddc9,
and also backs out references to isSearchable in the client and pg fns
@LoneRifle LoneRifle force-pushed the fix/is-searchable/remove branch from 2f52d0f to 7296e0b Compare November 16, 2020 08:21
@LoneRifle
fix(search): index shortUrl and desc unconditionally
eca5738 
Given that GoDirectory will use the index for government users and hence
will want all entries regardless of status and description, drop the
index conditions so that we can index the table in full.
@LoneRifle
chore(sql): add sql migration script to remove isSearchable
ac5c401
@LoneRifle LoneRifle force-pushed the fix/is-searchable/remove branch from 7296e0b to ac5c401 Compare November 16, 2020 08:59
yong-jie
yong-jie reviewed Nov 18, 2020
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@LoneRifle LoneRifle force-pushed the fix/is-searchable/remove branch from f9cb4c4 to ac5c401 Compare November 18, 2020 05:31
@yong-jie yong-jie merged commit bb1201f into develop Nov 18, 2020
@yong-jie yong-jie deleted the fix/is-searchable/remove branch November 18, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yong-jie yong-jie yong-jie approved these changes

@liangyuanruo liangyuanruo Awaiting requested review from liangyuanruo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LoneRifle @liangyuanruo @yong-jie