refactor(auth.client): (2) extract verify otp flow to Typescript #2086
+171
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing on Typescript 4.3.x, see Will figure out alternatives or a TS downgrade |
karrui
changed the title
This was referenced Jun 7, 2021
seaerchin
reviewed
Jun 7, 2021
src/public/modules/users/controllers/authentication.client.controller.js
Show resolved
Hide resolved
karrui
changed the title
mantariksh
reviewed
Jun 7, 2021
mantariksh
reviewed
Jun 7, 2021
karrui
force-pushed
the
feat/authservice-verify-userservice-ts
branch
from
94c0f3c to
5a03fa6
Compare
|
Ready for re-review |
mantariksh
approved these changes
Jun 9, 2021
src/public/modules/users/controllers/authentication.client.controller.js
Show resolved
Hide resolved
better fit API prefix
for mocking localstorage in the frontend jest tests
in preparation for extending from to close #2066
karrui
force-pushed
the
feat/authservice-verify-userservice-ts
branch
from
5a03fa6 to
aa596c9
Compare
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chain:
sendOtp<---verifyOtp(you are here)Problem
This PR is part 2 of migrating auth.client.js to Typescript. This PR extracts out the verify OTP function.
Related to #2057
Solution
Breaking Changes
Features:
Tests
verifyLoginOtpManual Tests
Deploy Notes
New dependencies:
zod: for writing agency and user base schemasdate-fnsfrom devDependencies to dependenciesdowngradeNot relevant in this PR, already merged in fix(deps): downgrade typescript to 4.2.4 #2092typescriptto4.2.4New dev dependencies:
jest-localstorage-mock: mock localstorage in frontend jest tests