refactor: convert CsvMergedHeadersGenerator to typescript #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantariksh
suggested changes
Jun 7, 2021
src/public/modules/forms/helpers/csv-response-classes/Response.class.ts
Outdated
Show resolved
Hide resolved
src/public/modules/forms/helpers/csv-response-classes/TableResponse.class.ts
Outdated
Show resolved
Hide resolved
src/public/modules/forms/helpers/csv-response-classes/SingleAnswerResponse.class.ts
Outdated
Show resolved
Hide resolved
mantariksh
suggested changes
Jun 9, 2021
seaerchin
reviewed
Jun 10, 2021
mantariksh
reviewed
Jun 14, 2021
tests/unit/frontend/forms/helpers/CsvMergedHeadersGenerator.test.js
Outdated
Show resolved
Hide resolved
karrui
requested changes
Jun 16, 2021
src/public/modules/forms/helpers/csv-response-classes/ArrayAnswerResponse.class.ts
Outdated
Show resolved
Hide resolved
src/public/modules/forms/helpers/csv-response-classes/Response.class.ts
Outdated
Show resolved
Hide resolved
src/public/modules/forms/helpers/csv-response-classes/SingleAnswerResponse.class.ts
Outdated
Show resolved
Hide resolved
src/public/modules/forms/helpers/csv-response-classes/TableResponse.class.ts
Outdated
Show resolved
Hide resolved
src/public/modules/forms/services/submissions.client.factory.js
Outdated
Show resolved
Hide resolved
src/public/modules/forms/services/submissions.client.factory.js
Outdated
Show resolved
Hide resolved
tests/unit/frontend/forms/helpers/CsvMergedHeadersGenerator.test.js
Outdated
Show resolved
Hide resolved
|
Can we also add more test cases with the additional response type checks? |
karrui
reviewed
Jun 17, 2021
karrui
approved these changes
Jun 21, 2021
mantariksh
approved these changes
Jun 21, 2021
mantariksh
reviewed
Jun 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR converts the
CsvMergedHeadersGeneratorto typescript.Closes #2030
Solution
Apart from converting the
CsvMergedHeadersGeneratorclass to typescript, the response classes incsv-response-classeswere also converted to typescript. Also, theResponseclass was converted to an abstract class, which cannot be instantiated. All subclass will have to implement the functionsgetAnswerandnumCols. This was done as the existing implementation inCsvMergedHeadersGeneratorimplies the need for all subclasses ofResponseto have the two aforementioned functions.Manual Tests
TableResponse), a checkbox field (to checkArrayAnswerResponse) and an email field (to checkSingleAnswerResponse). Submit a few responses and download the csv. Ensure that all answers to each form field are present in the csv and the metadata headers are also present.