-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): migrate file handler service to Typescript, update frontend test framework and lint #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MockAxios seems to have broken axios on the backend even though it's mocked only in public grrrrrrrrrrrrr |
uploads do not work (on staging) due to the flawed generation of md5, see https://stackoverflow.com/a/48482000 for more information. WIll fix. |
also make the code more performant on larger files
Tested on staging, upload, cancellation, all works! Appreciate a review. |
liangyuanruo
reviewed
Mar 1, 2021
liangyuanruo
reviewed
Mar 1, 2021
liangyuanruo
reviewed
Mar 1, 2021
src/public/modules/forms/admin/controllers/edit-fields-modal.client.controller.js
Show resolved
Hide resolved
liangyuanruo
approved these changes
Mar 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
First PR of many more to migrate angularjs services into plain Typescript services!
This PR migrates the old FileHandler angularjs service to FileHandlerService.
Also fixes jest to be able to run on arbitrary
*.test.ts*
files.Solution
Features:
FileHandlerService
instead of old client service, removefile-handler.client.service
Tests
Unit tests have been added for
FileHandlerService
.New dependencies:
New dev dependencies:
// Mock axios in tests + "jest-mock-axios": "^4.3.0",