Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow-up edits from PR #641 #668

Merged
merged 3 commits into from
Jan 31, 2022
Merged

follow-up edits from PR #641 #668

merged 3 commits into from
Jan 31, 2022

Conversation

There were still some outstanding comments/edits from the discussion in PR #641:

* Add explanatory text (#641 (comment))
* Removed definition of "collation" - it was not used in the text and it is not necessary to introduce the term (#641 (comment))
* Add "unicode normalization" as a term (#641 (comment))
* Add "unicode case folding" as a term (#641 (comment))
* Correct examples (#641 (comment))
@cportele
Copy link
Member Author

Another question is whether it should be "arguments" in the JSON representation of a function or "args" (like for the operators).

@pvretano
Copy link
Contributor

@cportele looks good ... go ahead and merge if you like.

@pvretano
Copy link
Contributor

@cportele about "arguments" or "args", we should be consistent across the board I think. Besides, "args" is shorter!

@cportele
Copy link
Member Author

OK, I have changed to "args" everywhere.

@cportele
Copy link
Member Author

@pvretano - Before merging, there is still the following note below requirement 9 that needs to be resolved:

The references in D need to be verified. Also need to have some discussion about NFC (cacnonically-composed form) or NFD (canonically decomposed form). I think the correct thing is to say that ACCENTI() must do NFC …​ but I need to verify.

@pvretano
Copy link
Contributor

Hmm ... why do we need to say anything about NFD or NFC? As long as one or the other is applied consistently in the implementation then code points should be comparable ... no?

@cportele
Copy link
Member Author

I guess so, but it was you who wrote that note :)

@pvretano
Copy link
Contributor

@cportele yeah because I was not sure but on further reflection I'm having second thoughts about getting into that level of detail. Perhaps we can discuss at today's meeting.

Meeting 2022-01-31: removing agreed
@cportele cportele merged commit ed0a671 into master Jan 31, 2022
@cportele cportele deleted the issue-630-pt2 branch January 31, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants