-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
follow-up edits from PR #641 #668
Conversation
There were still some outstanding comments/edits from the discussion in PR #641: * Add explanatory text (#641 (comment)) * Removed definition of "collation" - it was not used in the text and it is not necessary to introduce the term (#641 (comment)) * Add "unicode normalization" as a term (#641 (comment)) * Add "unicode case folding" as a term (#641 (comment)) * Correct examples (#641 (comment))
Another question is whether it should be "arguments" in the JSON representation of a function or "args" (like for the operators). |
@cportele looks good ... go ahead and merge if you like. |
@cportele about "arguments" or "args", we should be consistent across the board I think. Besides, "args" is shorter! |
OK, I have changed to "args" everywhere. |
@pvretano - Before merging, there is still the following note below requirement 9 that needs to be resolved:
|
Hmm ... why do we need to say anything about NFD or NFC? As long as one or the other is applied consistently in the implementation then code points should be comparable ... no? |
I guess so, but it was you who wrote that note :) |
@cportele yeah because I was not sure but on further reflection I'm having second thoughts about getting into that level of detail. Perhaps we can discuss at today's meeting. |
Meeting 2022-01-31: removing agreed
There were still some outstanding comments/edits from the discussion in PR #641: