Skip to content

Commit

Permalink
💄(react) add border-radius transition
Browse files Browse the repository at this point in the history
This transition was not working, now this provides are smoother effect.

Closes #112
  • Loading branch information
NathanVss committed Mar 13, 2024
1 parent 974f139 commit 8e7300b
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changeset/smooth-starfishes-suffer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@openfun/cunningham-react": minor
---

add border-radius transition
2 changes: 1 addition & 1 deletion packages/react/src/components/Forms/DatePicker/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
border-color: var(--c--components--forms-datepicker--border-color);
border-style: var(--c--components--forms-datepicker--border-style);
display: flex;
transition: border var(--c--theme--transitions--duration) var(--c--theme--transitions--ease-out);
transition: border var(--c--theme--transitions--duration) var(--c--theme--transitions--ease-out), border-radius var(--c--theme--transitions--duration) var(--c--theme--transitions--ease-out);
padding: 0 0.75rem;
gap: 1rem;
box-sizing: border-box;
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/Forms/Input/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
border-style: var(--c--components--forms-input--border-style);
background-color: var(--c--components--forms-input--background-color);
display: flex;
transition: border var(--c--theme--transitions--duration) var(--c--theme--transitions--ease-out);
transition: border var(--c--theme--transitions--duration) var(--c--theme--transitions--ease-out), border-radius var(--c--theme--transitions--duration) var(--c--theme--transitions--ease-out);
padding: 0 1rem;
gap: 1rem;
cursor: text;
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/Forms/Select/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
border-color: var(--c--components--forms-select--border-color);
border-style: var(--c--components--forms-select--border-style);
display: flex;
transition: border var(--c--theme--transitions--duration) var(--c--theme--transitions--ease-out);
transition: border var(--c--theme--transitions--duration) var(--c--theme--transitions--ease-out), border-radius var(--c--theme--transitions--duration) var(--c--theme--transitions--ease-out);
padding: 0 0.75rem;
gap: 1rem;
box-sizing: border-box;
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/Forms/TextArea/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
border-color: var(--c--components--forms-textarea--border-color);
border-style: var(--c--components--forms-textarea--border-style);
background-color: var(--c--components--forms-textarea--background-color);
transition: border var(--c--theme--transitions--duration) var(--c--theme--transitions--ease-out);
transition: border var(--c--theme--transitions--duration) var(--c--theme--transitions--ease-out), border-radius var(--c--theme--transitions--duration) var(--c--theme--transitions--ease-out);
overflow: hidden;

.labelled-box__label {
Expand Down

0 comments on commit 8e7300b

Please sign in to comment.