Always use Pydantic v1 API, test using v1 and v2 #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwthompson
changed the title
try with interchange-rc label packages unpin other openff deps actually order channels correctly remove interchange-rc channel Revert toolkit change Just use Pydantic v1 API, test both versions
mattwthompson
force-pushed
the
pydantic-always-v1
branch
from
ab93889
to
45c788c
Compare
for more information, see https://pre-commit.ci
|
The failures here are genuine, but could be due to hard-coded parts of the tests. I can't tell at the moment, but note that the traceback includes only files from upstreams. |
This was referenced Sep 9, 2024
mattwthompson
changed the title
|
seems like this could related to fastapi/fastapi#10360? |
|
Could be - I haven't used the V1 API backdoor in a project that also uses fastAPI and it wouldn't surprise me if that's not possible. I don't see any reason why this couldn't use V2, but it'd be some work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.