Fix JS errors in system specs #8361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Activating Stripe meant that other specs were trying to load the Stripe JS code without setting up Stripe correctly. That lead to JS errors in the console.
Re-raising console errors helps us to find subtle bugs.
jibees
approved these changes
Oct 15, 2021
filipefurtad0
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #8356
One of our specs was leaking the Stripe configuration into other specs. Activating Stripe meant that other specs were trying to load the Stripe JS code without setting up Stripe correctly. That lead to JS errors in the console. I'm fixing the issue and I'm activating JS fails again.
What should we test?
Green build.
Release notes
Changelog Category: Technical changes
Avoid state leakage from one spec to others.
Dependencies
There are a lot of current pull requests which move feature specs to system specs. While JS errors are not raised in master, any of those pull requests could introduce a new fail in combination with this PR. It would be good to merge this one first and then rebase the others.