Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last batch to fix error "subquery with too many columns" in rails 4 branch #4802

Merged
merged 2 commits into from
Mar 10, 2020

Conversation

luisramos0
Copy link
Contributor

@luisramos0 luisramos0 commented Feb 18, 2020

What? Why?

This PR closes #3708 as I dont see any more errors of this type in the 3-0-stable build.

What should we test?

I think a green build is enough here as the code change is pretty simple.

Release notes

Changelog Category: Changed
Prepare code for rails 4 upgrade.

@luisramos0 luisramos0 self-assigned this Feb 18, 2020
@luisramos0 luisramos0 changed the title Make select column explicit to avoid too many columns sql error Last batch to fix error "subquery with too many coolumns" in rails 4 branch Feb 18, 2020
@luisramos0 luisramos0 changed the title Last batch to fix error "subquery with too many coolumns" in rails 4 branch Last batch to fix error "subquery with too many columns" in rails 4 branch Feb 28, 2020
@sauloperez sauloperez merged commit 50cdda7 into openfoodfoundation:master Mar 10, 2020
@luisramos0 luisramos0 deleted the too_many branch March 10, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spree 2.1] Adapt to Rails 4 - subquery has too many columns
2 participants