Fix Rubocop violations in Stripe connect tests #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
approved these changes
Aug 14, 2019
|
the specs are broken in semaphore. |
|
Moving this back to Dev Backlog, the broken spec isn't going to be fixed before @sauloperez gets back so it can be moved back to Code Review when it's ready to go again. |
sauloperez
force-pushed
the
fix-styling-in-stripe-tests
branch
from
e9e1c23 to
f5ba784
Compare
sauloperez
force-pushed
the
fix-styling-in-stripe-tests
branch
from
f5ba784 to
1a45073
Compare
|
this should be in code review right Pau? |
|
yeah there was a flaky build error. rebuild was green |
|
Yes, sorry |
Matt-Yorkley
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Stems from #4127
It only fixes existing Rubocop violations of the Stripe Connect tests which makes them a bit more readable now that we're reviewing them.
What should we test?
Nothing, enough with the automated tests passing.
Release notes
Fixed Rubocop style violations from Stripe Connect tests
Category: Changed