Autocorrect rubocop Layout/BlockEndNewline cop #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I documented this process in https://github.com/openfoodfoundation/openfoodnetwork/wiki/Rubocop. My idea is to add more stuff related to the management of Rubocop, hence the title. Feel free to fix any typos/broken english. |
Matt-Yorkley
approved these changes
Feb 2, 2018
|
Is your idea to slowly autocorrect everything, one rule at a time? |
|
Yes, that is what I understood from our previous discussion on the topic. |
oeoeaio
approved these changes
Feb 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Autocorrects all the exclusions for the
Layout/BlockEndNewlineRubocop cop, so that the.rubocop_todo.ymlis now a little smaller.What should we test?
There's no behavior change.