[BUU] Activate admin_style_v3 for all system specs #12631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selects white_label tab with trigger(click) Scrolling down did no fix it, it still fails https://github.com/openfoodfoundation/openfoodnetwork/actions/runs/6526149195/job/17719815533?pr=11645, selecting the element with trigger(click) should work Updates invoice tests
This is a WIP branch, and each time we rebase we'll have some specs breaking. The changes in this commit mostly relate to the change in /admin/products URL, which points to the new BUU prodcts page; disabling the feature around related tests brings the branch back to green.
Removes migrated test from legacy product spec file
...adapted from ./spec/system/admin/bulk_product_update_spec.rb:23 Sets test as pending from issue openfoodfoundation#11060
Another option would have been to use page.find(:button, Save).trigger(click)
Deals with elements outside page range
Fixes overlapping elements
Comments assertion due to overlapping elements
Introduces a tom-select helper file
Moves existing tom select helper methods into separate file
under _describe search_ block
on the New variant button This test needs to be improved as, for Capybara, the text seems to be always visible, although it only does become visible by hovering.
This feature does not exist in BUU Replaces previous add variant button click with correct version
dacook
force-pushed
the
activate_buu_toggle_by_default_to_run_the_test_suite
branch
3 times, most recently
from
67d701b to
37900ba
Compare
These seem to have been changed since the previous rebase.
I'm not sure why it's not appearing on my computer, but it was an unnecessary duplicate message, so I'm happy to remove it.
It breaks due to a change of the spec environment. There's no point fixing it, it's no longer required.
dacook
force-pushed
the
activate_buu_toggle_by_default_to_run_the_test_suite
branch
from
37900ba to
916b503
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
WIP: opened separate PR for temporary review
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates