chore(deps-dev): bump rubocop-rails from 2.24.1 to 2.25.0 #12491
+16
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
force-pushed
the
dependabot/bundler/rubocop-rails-2.25.0
branch
from
315f331 to
e98ac81
Compare
|
This may be helpful https://github.com/openfoodfoundation/openfoodnetwork/wiki/Rubocop |
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.24.1 to 2.25.0. - [Release notes](https://github.com/rubocop/rubocop-rails/releases) - [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-rails@v2.24.1...v2.25.0) --- updated-dependencies: - dependency-name: rubocop-rails dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
The artificial limit of 100 years was just set because the old SQL query wouldn't deal with `null` well. Comparing with null always is always false and returns nothing. But Rails is now clever enough to interpret `begins_at..nil` as open end query. This shouldn't have any practical impact as there's unlikely to be an order cycle closing in more than 100 years. And if there was, it would be confusing that it's not treated like other order cycles ending in 80 years.
mkllnk
force-pushed
the
dependabot/bundler/rubocop-rails-2.25.0
branch
from
e98ac81 to
f9d436b
Compare
|
This has been sitting around for the best part of a year and I would like the newest rubocop-rails features. So I'm picking this up. It shouldn't take long. |
mkllnk
force-pushed
the
dependabot/bundler/rubocop-rails-2.25.0
branch
from
812f946 to
f8788d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop-rails from 2.24.1 to 2.25.0.
Release notes
Sourced from rubocop-rails's releases.
Changelog
Sourced from rubocop-rails's changelog.
Commits
809fd54Cut 2.25.00576d54Update Changelog171e6deMerge pull request #1279 from tldn0718/fix-skip-model-validation-safe-navigator40d9dc3[Fix rubocop#1278] Fix a false positivie for Rails/SkipsModelValidations582af1eMerge pull request #1277 from thiago-gitlab/rails-pick-descriptionacc1f4fWarn about subqueries when replacing pluck with pickb2c2450Merge pull request #1275 from koic/restore_skipping_specs_for_prism507c88cMerge pull request #1265 from ccutrer/not-null-column-docs4f43d8fRestore skipped specs for Prism1e4f28bMerge pull request #1266 from ccutrer/inspect_change_table_for_not_null_columnYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)