Do not show cookies banner once user accept it

[jibees]

Once the user accept the cookie, we should not show the cookie banner element. This is handled via app/helpers/footer_links_helper.rb#cookies_policy_link and boolean:

!Web::CookiesConsent.new(cookies, request.host).exists? && Spree::Config.cookies_consent_banner_toggle

As far as I know, this could not be revealed by automatic specs since we don't use cache in test env.

openfoodnetwork/spec/system/consumer/cookies_spec.rb

Lines 20 to 26 in 3cd53cb

	scenario "does not show after cookies are accepted" do
	accept_cookies_and_wait
	expect_not_visible_cookies_banner
	visit_root_path_and_wait
	expect_not_visible_cookies_banner
	end

What? Why?

Closes #10882

What should we test?

0. Delete all cookies, or use a private session
1. Navigate between different pages in the shopfront.
2. Accept the cookies.
3. Note that the banner will be shown again and again.

Release notes

Changelog Category: User facing changes

[filipefurtad0]

this could not be revealed by automatic specs since we don't use cache in test env.

Nice, thanks for that tip @jibees. Indeed, If we run that spec with:

openfoodnetwork/config/environments/test.rb

Line 21 in 32d425d

config.action_controller.perform_caching = false

Set to true, the spec fails (in master) and passes with your code change ✨
I'll propose a spec in a separate PR.

(I'm still wondering where was this regression introduced...)

[jibees]

Thanks @filipefurtad0
We should include your suggestion on top of this PR. I could do it (I tried, not sure how to override this into the spec...)
This was probably introduced since #10772 I suppose.

[filipefurtad0]

I think I've found it @jibees.
(after trying this in several ways 😅)

It seems we have a caching: true tag for this, coming from our base spec helper:

openfoodnetwork/spec/base_spec_helper.rb

Lines 94 to 100 in 32d425d

	# Enable caching in any specs tagged with `caching: true`.
	config.around(:each, :caching) do |example|
	caching = ActionController::Base.perform_caching
	ActionController::Base.perform_caching = example.metadata[:caching]
	example.run
	ActionController::Base.perform_caching = caching
	end

We should probably run the whole spec with caching, right?

I've enabled it here a22fa19 / #10887.

[jibees]

Thanks! I've cherry picked your commit!

[mkllnk]

Great! 👍

[filipefurtad0]

Not related to this PR:
I wonder if we should enable cache for spec/services/terms_of_service_spec.rb...

[filipefurtad0]

Hey @jibees ,

Thanks for this quick fix. I've staged the PR and can confirm that, by following the steps you've pointed out:

• After deleting all cookies, or using a private session
• The cookie banner is displayed when visiting the shopfront
• After accepting the cookie policy, the banner is not displayed again

Some regression testing:

• logged in
• verified that the session is persistent
• checked out

All good, merging! 🚀

PS: signalling issue #10261, as I've bumped into it during these tests: