Remove unused currency from calculators

[dacook]

What? Why?

• Partially completes Fee calculators: Remove the currency input field #10272
• This is an alternative solution and closes For calculator fields, do not edit currency preference #10279

What should we test?

As in #10272 (comment) . For example:

• As an admin, when editing fees that include method, or fees that include calculator is Amount (flatrate, ...) you should not see Currency input and therefore you should be able to edit it.

Release notes

Changelog Category: User facing change

Documentation updates

The user guide already doesn't mention this field (eg https://guide.openfoodnetwork.org/basic-features/shopfront/shipping-methods#fee-calculators )

However it's already a bit confusing that you have to save/update before you can access the calculator values, so I've submitted a PR to update the user guide: openfoodfoundation/ofn-UserGuide#39

[jibees]

It's very simple and clever. Thanks a lot.

[jibees]

Shouldn't we clean the spree_preferences table via a db migration? Just thinking...

[dacook]

Ah, good question, I didn't think of that!

I tried reading the Spree documentation to get an overview and understand how it is stored, but I think it just confused me more. Instead I browsed the database and it became clearer:

open_food_network_dev=# select id, key, value_type, substr(value, 0, 32) from spree_preferences where key like '/calculator%/currency/%';
  id   |                 key                  | value_type | substr
-------+--------------------------------------+------------+---------
 15646 | /calculator/flat_rate/currency/1826  | string     | --- AUD+
       |                                      |            | ...    +
       |                                      |            |
 15644 | /calculator/per_item/currency/2009   | string     | --- AUD+
       |                                      |            | ...    +
       |                                      |            |
   317 | /calculator/flat_rate/currency/357   | string     | AUD
   337 | /calculator/per_item/currency/369    | string     | AUD
...
(533 rows)

(it looks like older ones are stored in plain text, newer in a yaml format. doesn't matter either way).

I don't know if Spree will automatically clean these up upon next save. And it probably doesn't matter. But now that I've come this far I will try cleaning up with a new PR.

[filipefurtad0]

Hey @dacook ,

I've checked the enterprise fees page before (left - we can see the currency field) and after staging the PR (right - we can see the currency field is removed):

Also, for payment methods:

For shipping methods, I believe this was removed elsewhere? (no difference between before and after staging this PR):

Edit: this is correct, it only appears in some calculators. Updating the testing notes on the next comment.

Good to go! Merging.

[filipefurtad0]

An addenda to the previous testing notes: on the edit pages for shipping and payment methods, and for the respective calculators, we can compare the removal from those in which they've previously appeared.

For shipping methods:

For payment methods:

Again - good to go.