Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest versions of rails and ruby #635

Closed
soilforlifeforms opened this issue Jul 24, 2015 · 5 comments
Closed

Update to latest versions of rails and ruby #635

soilforlifeforms opened this issue Jul 24, 2015 · 5 comments

Comments

@soilforlifeforms
Copy link

I am interested to know why rails 3 and ruby 1.9 are still being used in this project. Would this be something the authors would be interested in pulling if I update the software?

@pmackay
Copy link
Contributor

pmackay commented Jul 24, 2015

I think they're linked with the older version of Spree being used, and the reason Spree is not up-to-date is because its been quite heavily customised.
If you plan to look at doing updates, best to get more details from @RohanM first :)

@RohanM
Copy link
Contributor

RohanM commented Jul 28, 2015

I'd love to update Rails and Ruby to the latest versions. @pmackay has pretty much hit the nail on the head - the version of Spree we're using is incompatible with later versions of Rails, and although we've only made minimal changes to Spree itself (we have a fork, mostly with minor bug fixes and backported security updates), our code is coupled to some internal details of Spree which changed significantly from 1.3 to 2.0. This means that upgrading is a pretty significant task, and one that's hard to estimate. I'd be happy to accept a PR around this, but I'd recommend spending some time getting familiar with the system before attempting it, since it would require a strong knowledge of the internals. Let me know your thoughts, and keep in touch if you're having a shot at it.

@pmackay pmackay changed the title Is there a reason for outdated rails and ruby? Update to latest versions of rails and ruby Jul 30, 2015
@pmackay pmackay added this to the Icebox milestone Jul 30, 2015
@pmackay
Copy link
Contributor

pmackay commented Aug 22, 2015

Another good reason to update - https://spreecommerce.com/blog/security-updates-2015-3-3. May not affect our current branch but keeping uptodate makes security patches easier to deploy.

@kirstenalarsen
Copy link
Contributor

no shortage of reasons to update, it’s resources that’s the problem :)

On 22 Aug 2015, at 9:15 pm, Paul Mackay [email protected] wrote:

Another good reason to update - https://spreecommerce.com/blog/security-updates-2015-3-3 https://spreecommerce.com/blog/security-updates-2015-3-3. May not affect our current branch but keeping uptodate makes security patches easier to deploy.


Reply to this email directly or view it on GitHub #635 (comment).

@pmackay
Copy link
Contributor

pmackay commented May 30, 2016

Now on Ruby 2 and Rohan working on Spree upgrade. Closing as this is general and its being handled elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants