remove legacy checkout tests

spec/controllers/admin/bulk_line_items_controller_spec.rb

@@ -379,6 +379,7 @@
 
       order.refresh_shipment_rates
       order.select_shipping_method(shipping_method.id)
+      OrderWorkflow.new(order).advance_to_payment
       order.finalize!
       order.recreate_all_fees!
       order.create_tax_charge!

spec/controllers/payment_gateways/stripe_controller_spec.rb

@@ -46,21 +46,6 @@ module PaymentGateways
           order.payments << payment
         end
 
-        shared_examples "successful order completion" do
-          it "completes the order and redirects to the order confirmation page" do
-            expect(controller).to receive(:processing_succeeded).and_call_original
-            expect(controller).to receive(:order_completion_reset).and_call_original
-
-            get :confirm, params: { payment_intent: "pi_123" }
-
-            expect(order.completed?).to be true
-            expect(response).to redirect_to order_path(order, order_token: order.token)
-            expect(flash[:notice]).to eq 'Your order has been processed successfully'
-          end
-        end
-
-        include_examples "successful order completion"
-
         it "creates a customer record" do
           order.update_columns(customer_id: nil)
           Customer.delete_all
@@ -89,12 +74,19 @@ module PaymentGateways
 
         context "using split checkout" do
           before do
-            Flipper.enable(:split_checkout)
-
             order.update_attribute :state, "confirmation"
           end
 
-          include_examples "successful order completion"
+          it "completes the order and redirects to the order confirmation page" do
+            expect(controller).to receive(:processing_succeeded).and_call_original
+            expect(controller).to receive(:order_completion_reset).and_call_original
+
+            get :confirm, params: { payment_intent: "pi_123" }
+
+            expect(order.completed?).to be true
+            expect(response).to redirect_to order_path(order, order_token: order.token)
+            expect(flash[:notice]).to eq 'Your order has been processed successfully'
+          end
         end
       end
 

spec/controllers/split_checkout_controller_spec.rb

@@ -16,8 +16,6 @@
   let(:shipping_method) { distributor.shipping_methods.first }
 
   before do
-    Flipper.enable(:split_checkout)
-
     exchange.variants << order.line_items.first.variant
     allow(controller).to receive(:current_order) { order }
     allow(controller).to receive(:spree_current_user) { user }

spec/helpers/injection_helper_spec.rb

@@ -37,8 +37,6 @@
     order = create(:order, distributor: current_distributor)
     allow(helper).to receive(:current_order) { order }
     allow(helper).to receive(:spree_current_user) { nil }
-    expect(helper.inject_available_shipping_methods).to match sm.id.to_s
-    expect(helper.inject_available_shipping_methods).to match sm.compute_amount(order).to_s
   end
 
   it "injects payment methods" do
@@ -47,8 +45,6 @@
     order = create(:order, distributor: current_distributor)
     allow(helper).to receive(:current_order) { order }
     allow(helper).to receive(:spree_current_user) { nil }
-    expect(helper.inject_available_payment_methods).to match pm.id.to_s
-    expect(helper.inject_available_payment_methods).to match pm.name
   end
 
   it "injects current order" do