-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Ruby 2.2.10 #530
Install Ruby 2.2.10 #530
Conversation
Tested and working! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make CI pass
Yep, there's an issue here that needs addressing: openfoodfoundation/openfoodnetwork#4301 |
moved to in dev and marked as blocked by 4301 |
As per the previous Ruby bump:
The |
I feel like this is still too manual. I'd be much easier to manage if we installed both the current and feature version so that the infra is ready to manage the app running in either version. As a result of the decoupling, we could freely merge the ofn-install PR and have it run either app version and so no need to sync merges and provisions. Next time, I guess. |
Looks like the role we use https://github.com/zzet/ansible-rbenv-role supports passing a list of ruby versions but also removes any existing ones. So it's should be pretty straightforward to do. |
It only removes old versions if you set a specific variable. So the previous version will still be available. |
ok, build is green. |
I merged 4310, checked green builds on both ofn and ofn-install. Provisioned both staging FR and staging UK. Both looking good. I am merging this now.
|
Install Ruby 2.2.10
Part 2 of: openfoodfoundation/openfoodnetwork#2891
Provisions Ruby
2.2.10
ready for use with PR: openfoodfoundation/openfoodnetwork#4301