Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Ruby 2.2.10 #530

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

Matt-Yorkley
Copy link
Collaborator

@Matt-Yorkley Matt-Yorkley commented Sep 23, 2019

Part 2 of: openfoodfoundation/openfoodnetwork#2891

Provisions Ruby 2.2.10 ready for use with PR: openfoodfoundation/openfoodnetwork#4301

@Matt-Yorkley
Copy link
Collaborator Author

Tested and working! 🎉

Copy link
Contributor

@sauloperez sauloperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make CI pass

@Matt-Yorkley
Copy link
Collaborator Author

Matt-Yorkley commented Oct 11, 2019

Yep, there's an issue here that needs addressing: openfoodfoundation/openfoodnetwork#4301

@luisramos0
Copy link
Contributor

moved to in dev and marked as blocked by 4301

@Matt-Yorkley
Copy link
Collaborator Author

Matt-Yorkley commented Oct 17, 2019

As per the previous Ruby bump:

The build will not have both versions installed because it's starting from a fresh server, installing 2.2.10 and then deploying master (using 2.1.9).

The ofn-install CI build will be green when the master branch of the main repo uses 2.2.10.

@sauloperez
Copy link
Contributor

sauloperez commented Nov 6, 2019

I feel like this is still too manual. I'd be much easier to manage if we installed both the current and feature version so that the infra is ready to manage the app running in either version. As a result of the decoupling, we could freely merge the ofn-install PR and have it run either app version and so no need to sync merges and provisions.

Next time, I guess.

@sauloperez
Copy link
Contributor

Looks like the role we use https://github.com/zzet/ansible-rbenv-role supports passing a list of ruby versions but also removes any existing ones. So it's should be pretty straightforward to do.

@Matt-Yorkley
Copy link
Collaborator Author

It only removes old versions if you set a specific variable. So the previous version will still be available.

@luisramos0
Copy link
Contributor

ok, build is green.

@luisramos0
Copy link
Contributor

I merged 4310, checked green builds on both ofn and ofn-install. Provisioned both staging FR and staging UK. Both looking good. I am merging this now.
We need to provision all other servers afterwards:

  • ka staging
  • au staging
  • uk prod
  • au prod
  • fr prod
  • ka prod
  • ca prod
  • us prod
  • de prod
  • be prod

@luisramos0 luisramos0 merged commit 6984187 into openfoodfoundation:master Nov 7, 2019
jsia9 pushed a commit to jsia9/ofn-install that referenced this pull request Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants