Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error when adding child to node with no children #447

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix: error when adding child to node with no children #447

merged 1 commit into from
Mar 14, 2024

Conversation

perierc
Copy link
Contributor

@perierc perierc commented Mar 14, 2024

What

  • This PR fixes the impossibility to add a child to a node that has currently no children.
  • The error was due to a wrong Neo4J query in the update_node_children function in the backend.

Fixes bug(s)

@perierc perierc requested a review from a team as a code owner March 14, 2024 00:10
alexgarel
alexgarel approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

Good mastering of cipher :-)

@alexgarel alexgarel merged commit f74cfdf into main Mar 14, 2024
9 checks passed
@alexgarel alexgarel deleted the perierc/fix-add-child-to-node-with-no-children branch March 14, 2024 16:00
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@perierc perierc

Labels
backend
Projects
No open projects
🧬 Taxonomy editor - gsoc 2022
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot add new child when there is no children currently
2 participants
@perierc @alexgarel