Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Initialize edit entry page #44

Merged
merged 12 commits into from
Aug 29, 2022
Merged

feat: Initialize edit entry page #44

merged 12 commits into from
Aug 29, 2022

Conversation

aadarsh-ram
Copy link
Collaborator

What

  • Initialize all components for the "edit entry" page
  • ListAllTranslations.jsx finished

@aadarsh-ram aadarsh-ram requested a review from a team as a code owner August 14, 2022 07:03
nobeeakon
nobeeakon reviewed Aug 29, 2022
View reviewed changes
taxonomy-editor-frontend/src/pages/editentry/ListTranslations.jsx
{
nodeObject["tags_"+nodeObject['main_language']].map((tag, index) => {
return (
<Paper key={index} component={Stack} direction="column" sx={{ml: 4, width: 200}}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what´s the need of the stack if it only cotains one single element inside? should it be wrapping the ...map(tag, index)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, do not use index as key

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nobeeakon This will be recitified in a future PR with the use of a UUID. Currently, since any updates aren't happening in this current version, it has index as key.

nobeeakon
nobeeakon approved these changes Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@nobeeakon nobeeakon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@nobeeakon nobeeakon merged commit 87c23e0 into main Aug 29, 2022
@nobeeakon nobeeakon deleted the editentryinit branch August 29, 2022 14:40
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobeeakon nobeeakon nobeeakon approved these changes

Assignees

@aadarsh-ram aadarsh-ram

Labels
None yet
Projects
No open projects
🧬 Taxonomy editor - gsoc 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aadarsh-ram @nobeeakon