docs: document the way to load samples #23
Conversation
* there is now a `is_before` relationship instead of block_index * change the way to store tags and tags ids and uniformized among node entries * add labels to nodes * add a footer node
aadarsh-ram
changed the title
in taxonomy parsing spec and in sample json for neo4j.
There was a problem hiding this comment.
Hi @alexgarel, these are just a few small changes I noticed.
Co-authored-by: Aadarsh A <[email protected]>
|
Ah i forgot but, should the src_position you mentioned also be in the json file or it's only for the database ? |
I'm not sure what you are talking about @BryanH01 |
@BryanH01 I think the Parser needs to generate a JSON according to the new format @alexgarel has created, so that it can be directed loaded into Neo4J. So, the property "src_position" would be used for debugging within the Parser program, but not stored in the JSON. @alexgarel @BryanH01 is my intiution correct? |
|
Ah I'm sorry, you talk about it here when reviewing |
I'm sorry, I'm not being clear, i was talking about the test-neo4j.json file. The parser that I'm writing directly add the data in neo4j, I don't generate json. |
|
yes @aadarsh-ram , @BryanH01 is generating the Neo4J data directly, and that's what we want. The json file is just for you to have some data to start with, and also was really useful at defining data structure more precisely. |
Co-authored-by: Aadarsh A <[email protected]>
|
@alexgarel @BryanH01 Really sorry! Got a little bit confused with the programs. Thanks for the clarification! |
|
@BryanH01, you're right, I should add the "src_position" stuff to the spec, also in the sample to be constistent :-) I forgot about it ! Will do. |
|
@BryanH01 I added the src_position. |
| * preceding *comments lines* in a `preceeding_lines` property | ||
| * preceding *comments lines* in a `preceding_lines` property | ||
| * the start of the entry block in a property `src_position`. First line is 1. | ||
| Comments (aka `preceding_lines`) are not accounted as block start, but for footer and header. | ||
|
|
||
| We also add a `is_before` link between nodes, to keep order in which nodes where found in the file. |
There was a problem hiding this comment.
| We also add a `is_before` link between nodes, to keep order in which nodes where found in the file. | |
| We also add a `is_before` link between nodes, to keep order in which nodes were found in the file. |
What
Part of