-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initialize edit entry page #44
Conversation
taxonomy-editor-frontend/src/pages/editentry/AccumulateAllComponents.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListAllProperties.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListAllProperties.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListAllOtherProperties.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListAllOtherProperties.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListAllEntryProperties.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListAllEntryProperties.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListAllOtherProperties.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/AccumulateAllComponents.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListTranslations.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListTranslations.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListTranslations.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListAllEntryProperties.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListTranslations.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListTranslations.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListAllEntryProperties.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListTranslations.jsx
Outdated
Show resolved
Hide resolved
{ | ||
nodeObject["tags_"+nodeObject['main_language']].map((tag, index) => { | ||
return ( | ||
<Paper key={index} component={Stack} direction="column" sx={{ml: 4, width: 200}}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what´s the need of the stack if it only cotains one single element inside? should it be wrapping the ...map(tag, index)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, do not use index
as key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nobeeakon This will be recitified in a future PR with the use of a UUID. Currently, since any updates aren't happening in this current version, it has index as key.
taxonomy-editor-frontend/src/pages/editentry/AccumulateAllComponents.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/AccumulateAllComponents.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/AccumulateAllComponents.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/AccumulateAllComponents.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/AccumulateAllComponents.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListTranslations.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work
What