-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ext-gd as dev. dependency #65
base: develop
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @epalmans 👌
thanks for approving.... but a bit reluctant to see it merged&tagged though due to this: #53 (comment) |
Add the user-agent as first parameter help us to force developer to add it, if it was the last, it will never used. -- |
@Benoit382 Every code using this library will then have to adapt - please consider - also the laravel plugin of @epalmans |
another thought... we could keep the constructor like it was before, but now check for the User-Agent request header. Then, if it's missing, return a 403 with an errormessage? |
@Benoit382 I don't have massive opinions. We proposed that as we were overwhelmed with queries. |
(and sorry for the delay, I was in holidays last week) |
What
Use of
ext-gd
appears to only be required in tests (throughimagepng()
call), introduced in #47. Therefore, proposing to move from require to require-devFixes bug(s)