Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup deps and remove sqlite3 system requirement #359

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Cleanup deps and remove sqlite3 system requirement #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ jobs:
working_directory: /go/src/github.com/checkr/flagr
steps:
- checkout
- run: apt update && apt install -y sqlite3
- run: make deps
- run: make ci
- run: bash <(curl -s https://codecov.io/bash)
Expand Down
7 changes: 1 addition & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,11 @@ start:

gen: api_docs swagger

deps: checks
deps:
@GO111MODULE=off go get -u github.com/myitcv/gobin
@gobin github.com/go-swagger/go-swagger/cmd/[email protected]
@gobin github.com/codeskyblue/fswatch
@gobin github.com/golangci/golangci-lint/cmd/[email protected]
@echo "Sqlite3" && sqlite3 -version

watch:
@fswatch
Expand All @@ -61,10 +60,6 @@ api_docs:
@echo "Installing swagger-merger" && npm install swagger-merger -g
@swagger-merger -i $(PWD)/swagger/index.yaml -o $(PWD)/docs/api_docs/bundle.yaml

checks:
@echo "Check deps"
@(env bash $(PWD)/buildscripts/checkdeps.sh)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to check deps or in GOPATH, flagr is fully on go.mod and each build/run go command comes with GO111MODULE=on


verifiers: verify_lint verify_swagger

verify_lint:
Expand Down
176 changes: 0 additions & 176 deletions buildscripts/checkdeps.sh
View file
Open in desktop

This file was deleted.

38 changes: 0 additions & 38 deletions buildscripts/demo.py
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions buildscripts/get_remote_sqlite.sh
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions buildscripts/publish_to_docker.sh
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion docs/home.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ Install Dependencies.
- Go
- Make (for Makefile)
- NPM (for building UI)
- SQLite3 (for testing)

Build from source.

Expand Down