-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for validating HS512 JWT tokens #282
Conversation
Thanks! Can you also update https://github.com/checkr/flagr/blob/master/pkg/config/env.go#L166? |
bf64dc3
to
a282f2a
Compare
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
=========================================
+ Coverage 81.76% 81.8% +0.03%
=========================================
Files 26 26
Lines 1530 1533 +3
=========================================
+ Hits 1251 1254 +3
Misses 210 210
Partials 69 69
Continue to review full report at Codecov.
|
Updated |
pkg/config/middleware_test.go
Outdated
Config.JWTAuthEnabled = true | ||
Config.JWTAuthSecret = "mysecret" | ||
Config.JWTAuthSigningMethod = "HS512" | ||
Config.JWTAuthDebug = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, I don't think you need to set Config.JWTAuthDebug = true
here, if so, please also unset it in the defer function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed it.
🎉 |
@zhouzhuojie Can you deploy the latest changes to docker hub? |
Done. Also opened an issue about auto release. #292 |
Added support for validating HS512 JWT tokens
Description
added a hs512 case to handle the tokens
Motivation and Context
We have JWT tokens signed by HS512 method. Its was throwing invalid signature. So had to add this extension
How Has This Been Tested?
I have added tests with valid HS512 signed tokens