Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to output logs in JSON format #253

Merged

Conversation

croemmich
Copy link
Contributor

Description

Adds the ability to use the Logrus JSONFormatter.

Motivation and Context

Allows for simple end-to-end structured logging via Docker -> Fluentd -> ElasticSearch.

How Has This Been Tested?

Tested manually. Ensured new and default behavior.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #253 into master will decrease coverage by 0.18%.
The diff coverage is 42.85%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #253      +/-   ##
========================================
- Coverage   82.18%    82%   -0.19%     
========================================
  Files          26     26              
  Lines        1521   1528       +7     
========================================
+ Hits         1250   1253       +3     
- Misses        203    207       +4     
  Partials       68     68
Impacted Files Coverage Δ
pkg/config/config.go 79.1% <42.85%> (-4.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f65dacf...476e43c. Read the comment docs.

Copy link
Collaborator

@zhouzhuojie zhouzhuojie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left one comment

@croemmich croemmich force-pushed the feature/logrus-json-format branch from 95b9b0a to 476e43c Compare May 13, 2019 17:16
@zhouzhuojie zhouzhuojie merged commit 11a33a8 into openflagr:master May 13, 2019
@croemmich croemmich deleted the feature/logrus-json-format branch May 14, 2019 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants