Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove entity_type statsd tag #242

Merged
merged 1 commit into from
Mar 23, 2019
Merged

Conversation

zhouzhuojie
Copy link
Collaborator

r.EvalContext.EntityType has really high cardinality, removing it to save the datadog's 1k per metric limit.

@zhouzhuojie zhouzhuojie requested a review from ziru March 23, 2019 09:39
@codecov-io
Copy link

codecov-io commented Mar 23, 2019

Codecov Report

Merging #242 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
+ Coverage   82.51%   82.56%   +0.05%     
==========================================
  Files          25       25              
  Lines        1441     1440       -1     
==========================================
  Hits         1189     1189              
+ Misses        193      192       -1     
  Partials       59       59
Impacted Files Coverage Δ
pkg/handler/eval.go 77.45% <ø> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f3c10d...dd9a008. Read the comment docs.

@zhouzhuojie zhouzhuojie force-pushed the zz/remove-entity-type-statsd-tag branch from 7e8e460 to dd9a008 Compare March 23, 2019 09:43
@zhouzhuojie zhouzhuojie merged commit 954c056 into master Mar 23, 2019
@zhouzhuojie zhouzhuojie deleted the zz/remove-entity-type-statsd-tag branch March 23, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants