Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use English as default locale for flagr instead of Chinese #226

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Use English as default locale for flagr instead of Chinese #226

merged 1 commit into from
Feb 28, 2019

Conversation

lawrenceong
Copy link
Contributor

Description

As the contents for flagr is in English, set the default locale for
ElementUI to English (instead of defaulting to Chinese). This is to
prevent certain contents from being displayed in Chinese. eg. when
there are no flags available.

Motivation and Context

Keep the language consistent in the application.

How Has This Been Tested?

Launch the default flagr and run it using docker:

Before the change, confirm that the bug is present by launching a docker container as such:

docker run -p 18000:18000 checkr/flagr

Visit the GUI and delete all flags. You will see No Data in Chinese written as 暂无数据.

Test the change and launch a docker container with the change. You will see No Data.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

As the contents for flagr is in English, set the default locale for
ElementUI to English (instead of defaulting to Chinese).  This is to
prevent certain contents from being displayed in Chinese.  eg. when
there are no flags available.
@codecov-io
Copy link

Codecov Report

Merging #226 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files          24       24           
  Lines        1433     1433           
=======================================
  Hits         1202     1202           
  Misses        174      174           
  Partials       57       57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 608d017...df559ee. Read the comment docs.

Copy link
Collaborator

@zhouzhuojie zhouzhuojie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@zhouzhuojie zhouzhuojie merged commit 94800ff into openflagr:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants