Bump conditions #219
Merged
Bump conditions #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouzhuojie
force-pushed
the
zz/bump-conditions
branch
from
8ef6a79 to
cc81e98
Compare
|
flame graph
No more bottlenecks on the evaluation code path |
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
==========================================
- Coverage 85.55% 85.31% -0.24%
==========================================
Files 24 23 -1
Lines 1385 1376 -9
==========================================
- Hits 1185 1174 -11
- Misses 145 146 +1
- Partials 55 56 +1
Continue to review full report at Codecov.
|
zhouzhuojie
force-pushed
the
zz/bump-conditions
branch
from
cc81e98 to
3bed3b0
Compare
zhouzhuojie
commented
Feb 13, 2019
| @@ -252,7 +252,10 @@ var evalSegment = func( | |||
| return vID, log, false | |||
| } | |||
|
|
|||
| func debugConstraintMsg(expr conditions.Expr, m map[string]interface{}) string { | |||
| func debugConstraintMsg(enableDebug bool, expr conditions.Expr, m map[string]interface{}) string { | |||
| if !enableDebug { | |||
There was a problem hiding this comment.
to avoid unnecessary serialization of constraint if enableDebug is false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the revert of the bump ecfd3bd
This pr only includes the changes we want