Add kafka version config #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouzhuojie
commented
Nov 10, 2018
| @@ -67,6 +67,7 @@ var Config = struct { | |||
| RecorderType string `env:"FLAGR_RECORDER_TYPE" envDefault:"kafka"` | |||
|
|
|||
| // Kafka related configurations for data records logging (Flagr Metrics) | |||
| RecorderKafkaVersion string `env:"FLAGR_RECORDER_KAFKA_VERSION" envDefault:"0.8.2.0"` | |||
There was a problem hiding this comment.
This is the default sarama setting
There was a problem hiding this comment.
consider using 0.11+?
0.8 is too old. not including timestamp in record as well.
There was a problem hiding this comment.
using 0.11+ as default is a breaking change, I will set it manually for Checkr.
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
+ Coverage 90.85% 90.88% +0.03%
==========================================
Files 25 25
Lines 1410 1415 +5
==========================================
+ Hits 1281 1286 +5
Misses 96 96
Partials 33 33
Continue to review full report at Codecov.
|
rstratton
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add kafka version configuration