Publish to conda #43

benoit-cty · 2022-02-15T16:37:47Z

Technical improvement.
Details:
- Publish to conda in CI
- Move CI from Circle CI to Github Action as it is the case for others OpenFisca projects

These changes change non-functional parts of this repository : CI.

benoit-cty · 2022-02-17T15:17:59Z

Run OK for conda : https://github.com/openfisca/extension-template/actions/runs/1859207665

sandcha · 2022-04-07T07:55:56Z

Hello @benoit-cty, Thank you for this new feature(s)!
This PR does more than publishing to conda, it also migrates the CI checks from CircleCI to GitHub Actions. Could you explicit why you made this choice? And the list of credentials/rights to activate on this repository? 🙂

benoit-cty · 2022-04-07T14:27:16Z

I move CI from Circle CI to Github Action as it is the CI used for others OpenFisca projects.
And, honestly, also because I already have the code for Conda in Github Action.

The credential is already on the organization level, it is secrets.ANACONDA_TOKEN

sandcha

Thank you @benoit-cty for this new conda installation! Tested and it woks 🙌
The main requests are:

remove the old circleci configuration as we are migrating the CI to GitHub Action here,
fix some typo.

sandcha · 2022-05-19T06:44:23Z

.conda/README.md

@@ -0,0 +1,32 @@
+# Publish to conda
+
+There is two way of publishing to conda:


The documentation is similar to conda documentation in openfisca-core. You might find some similar comments/this review not entirely original 😅

Suggested change

There is two way of publishing to conda:

There are two ways of publishing to conda:

sandcha · 2022-05-19T06:46:32Z

.conda/README.md

+# Publish to conda
+
+There is two way of publishing to conda:
+- A fully automatic in CI that publish to an "openfisca" channel. See below for more information.


Typo and standardization of style:

Suggested change

- A fully automatic in CI that publish to an "openfisca" channel. See below for more information.

- A fully automatic in CI that publishes to an `openfisca` channel. See below for more information.

sandcha · 2022-05-19T06:47:44Z

.conda/README.md

+
+There is two way of publishing to conda:
+- A fully automatic in CI that publish to an "openfisca" channel. See below for more information.
+- A more complex for Conda-Forge.


Add link to help the reader and remove any ambiguity?

Suggested change

- A more complex for Conda-Forge.

- A more complex for [Conda-Forge](https://conda-forge.org).

sandcha · 2022-05-19T06:48:34Z

.conda/README.md

+- A fully automatic in CI that publish to an "openfisca" channel. See below for more information.
+- A more complex for Conda-Forge.
+
+We use both for openfisca-core but only _openfisca channel_ for _extension-template_.


Minor suggestion:

Suggested change

We use both for openfisca-core but only _openfisca channel_ for _extension-template_.

We use both for openfisca-core but only `openfisca` channel for `extension-template`.

sandcha · 2022-05-19T06:50:00Z

.conda/README.md

+
+## Automatic upload
+
+The CI automaticaly upload the PyPi package, see the `.github/workflow.yml`, step `publish-to-conda`.


Explicit which package as the next steps will depend on it?

Suggested change

The CI automaticaly upload the PyPi package, see the `.github/workflow.yml`, step `publish-to-conda`.

The CI automaticaly upload the [PyPi package](https://pypi.org/project/OpenFisca-Extension-Template/), see the `.github/workflow.yml`, step `publish-to-conda`.

sandcha · 2022-05-24T10:23:05Z

README.md

+- `conda activate openfisca-ext-tplt` to use your new environment.
+- `conda install -c openfisca openfisca-extension-template` to install the package and all dependencies.
+
+Conda is the easiest way to use OpenFisca under Windows as by installing Anaconda you will get:


Just after ## Installing section, add a sentence to help the user chose between the installation options? Use a part of the sentence above?

## Installing [conda](https://docs.conda.io) is the easiest way to use OpenFisca under Windows. On other OS systems, the default installation is based on [pip](https://pip.pypa.io/en/stable/) Python package installer.

sandcha · 2022-05-24T11:44:59Z

README.md

+- A virtual environment manager : [conda](https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html)
+- A GUI [Anaconda Navigator](https://docs.anaconda.com/anaconda/navigator/index.html) if you choose to install the full [Anaconda](https://www.anaconda.com/products/individual)
+
+If you are familiar with command line you could use [Miniconda](https://docs.conda.io/projects/conda/en/latest/user-guide/install/windows.html), wich need very much less disk space than Anaconda.


Suggested change

If you are familiar with command line you could use [Miniconda](https://docs.conda.io/projects/conda/en/latest/user-guide/install/windows.html), wich need very much less disk space than Anaconda.

If you are familiar with command line you could use [Miniconda](https://docs.conda.io/projects/conda/en/latest/user-guide/install/windows.html), which needs very much less disk space than Anaconda.

Add explicit that the commands given above will then work in a shell terminal?

sandcha · 2022-05-24T11:47:05Z

README.md

+
+If you are familiar with command line you could use [Miniconda](https://docs.conda.io/projects/conda/en/latest/user-guide/install/windows.html), wich need very much less disk space than Anaconda.
+
+For informations on how we publish to conda-forge, see [README](.conda/README.md).


Suggestion:

Suggested change

For informations on how we publish to conda-forge, see [README](.conda/README.md).

For informations on how we publish to [conda-forge](https://conda-forge.org), see [README](.conda/README.md).

sandcha · 2022-05-24T11:50:24Z

README.md

+### Installing with conda
+
+Since version [1.3.11](https://anaconda.org/openfisca/openfisca-extension-template), you could use conda to install OpenFisca-Extension-Template with these commands to run in `Anaconda Powershell Prompt` :
+- `conda create --name openfisca-ext-tplt python=3.7` to create an openfisca environment.


Suggested change

- `conda create --name openfisca-ext-tplt python=3.7` to create an openfisca environment.

- `conda create --name openfisca-ext-tplt python=3.7` to create an `openfisca-ext-tplt` virtual environment.

sandcha · 2022-05-24T11:58:28Z

README.md

+- `conda create --name openfisca-ext-tplt python=3.7` to create an openfisca environment.
+- `conda activate openfisca-ext-tplt` to use your new environment.
+- `conda install -c openfisca openfisca-extension-template` to install the package and all dependencies.


👍 Tested without error on local environment by following these steps and then, running openfisca test openfisca_extension_template/tests/local_benefit.yaml -e openfisca_extension_template.

sandcha · 2022-05-24T12:06:44Z

@benoit-cty Juste a reminder to us both: upon this PR merge, we will need:

to update this repository settings to remove the circleci check. 🙂
check if there is something to remove from CircleCI configuration.

As said before ANACONDA_TOKEN secret is already set for this repository.

MattiSG · 2022-12-12T08:27:19Z

Following #51, the Github Actions migration has been handled. This changeset can (and should) thus be updated to remove that part 🙂

benoit-cty added 15 commits February 15, 2022 17:33

Add conda publish

90dcd20

Remove lint

04672d1

Move workflow

6969e66

Disable CircleCI

1fc2e83

Rename to workflows

bca35e2

Fix needs

0cba2d9

Bump version

5be1c36

Add get_pypi_info script

9ffc1ab

Fix deps

df73a0c

Fix version

043e5a1

Add openfisca channel

21fb04a

Add pytest

e637707

Remove openfisca test

ba5195c

Doc

2c6ea02

Conda only on master

3210a3c

benoit-cty requested a review from sandcha February 17, 2022 15:18

sandcha requested changes May 24, 2022

View reviewed changes

MattiSG mentioned this pull request Dec 12, 2022

Switch CI/CD to GitHub Actions #44

Closed

bonjourmauko added the kind:ci Changes to our CI configuration files and scripts label Sep 30, 2024

bonjourmauko mentioned this pull request Oct 3, 2024

ci: add matrix & fix conda openfisca/openfisca-core#1257

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Publish to conda #43

Publish to conda #43

benoit-cty commented Feb 15, 2022 •

edited

Loading

benoit-cty commented Feb 17, 2022

sandcha commented Apr 7, 2022

benoit-cty commented Apr 7, 2022 •

edited

Loading

sandcha left a comment •

edited

Loading

sandcha May 19, 2022

sandcha May 19, 2022

sandcha May 19, 2022

sandcha May 19, 2022

sandcha May 19, 2022

sandcha May 24, 2022

sandcha May 24, 2022

sandcha May 24, 2022

sandcha May 24, 2022

sandcha May 24, 2022

sandcha May 24, 2022

sandcha commented May 24, 2022 •

edited

Loading

MattiSG commented Dec 12, 2022

		@@ -0,0 +1,32 @@
		# Publish to conda

		There is two way of publishing to conda:

	There is two way of publishing to conda:
	There are two ways of publishing to conda:

	- A fully automatic in CI that publish to an "openfisca" channel. See below for more information.
	- A fully automatic in CI that publishes to an `openfisca` channel. See below for more information.

	- A more complex for Conda-Forge.
	- A more complex for [Conda-Forge](https://conda-forge.org).

	We use both for openfisca-core but only _openfisca channel_ for _extension-template_.
	We use both for openfisca-core but only `openfisca` channel for `extension-template`.


		## Automatic upload

		The CI automaticaly upload the PyPi package, see the `.github/workflow.yml`, step `publish-to-conda`.

	The CI automaticaly upload the PyPi package, see the `.github/workflow.yml`, step `publish-to-conda`.
	The CI automaticaly upload the [PyPi package](https://pypi.org/project/OpenFisca-Extension-Template/), see the `.github/workflow.yml`, step `publish-to-conda`.

	If you are familiar with command line you could use [Miniconda](https://docs.conda.io/projects/conda/en/latest/user-guide/install/windows.html), wich need very much less disk space than Anaconda.
	If you are familiar with command line you could use [Miniconda](https://docs.conda.io/projects/conda/en/latest/user-guide/install/windows.html), which needs very much less disk space than Anaconda.


		If you are familiar with command line you could use [Miniconda](https://docs.conda.io/projects/conda/en/latest/user-guide/install/windows.html), wich need very much less disk space than Anaconda.

		For informations on how we publish to conda-forge, see [README](.conda/README.md).

	For informations on how we publish to conda-forge, see [README](.conda/README.md).
	For informations on how we publish to [conda-forge](https://conda-forge.org), see [README](.conda/README.md).

	- `conda create --name openfisca-ext-tplt python=3.7` to create an openfisca environment.
	- `conda create --name openfisca-ext-tplt python=3.7` to create an `openfisca-ext-tplt` virtual environment.

Publish to conda #43

Are you sure you want to change the base?

Publish to conda #43

Conversation

benoit-cty commented Feb 15, 2022 • edited Loading

benoit-cty commented Feb 17, 2022

sandcha commented Apr 7, 2022

benoit-cty commented Apr 7, 2022 • edited Loading

sandcha left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sandcha commented May 24, 2022 • edited Loading

MattiSG commented Dec 12, 2022

benoit-cty commented Feb 15, 2022 •

edited

Loading

benoit-cty commented Apr 7, 2022 •

edited

Loading

sandcha left a comment •

edited

Loading

sandcha commented May 24, 2022 •

edited

Loading