feat(java): Configuration overrides #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Note: This is functional, but incomplete as it lacks unit tests We'll come back with tests soon and not consider the issue closed yet |
booniepepper
commented
Aug 23, 2023
config/clients/java/template/config-Configuration.java.mustache
Outdated
Show resolved
Hide resolved
adriantam
reviewed
Aug 23, 2023
config/clients/java/template/config-Configuration.java.mustache
Outdated
Show resolved
Hide resolved
booniepepper
commented
Aug 23, 2023
config/clients/java/template/config-Configuration.java.mustache
Outdated
Show resolved
Hide resolved
adriantam
approved these changes
Aug 24, 2023
booniepepper
added a commit
that referenced
this pull request
Aug 25, 2023
* refactor(java): Thread Configuration through request builders * refactor(java): Thread Configuration through requests * feat(java): Introduce ConfigurationOverride class * test(java): Add tests on ConfigurationOverride * refactor(java): Consistent code in Configuration.override(...)
booniepepper
added a commit
that referenced
this pull request
Aug 25, 2023
* refactor(java): Thread Configuration through request builders * refactor(java): Thread Configuration through requests * feat(java): Introduce ConfigurationOverride class * test(java): Add tests on ConfigurationOverride * refactor(java): Consistent code in Configuration.override(...)
booniepepper
added a commit
that referenced
this pull request
Sep 6, 2023
* refactor(java): Thread Configuration through request builders * refactor(java): Thread Configuration through requests * feat(java): Introduce ConfigurationOverride class * test(java): Add tests on ConfigurationOverride * refactor(java): Consistent code in Configuration.override(...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows Configuration to be overridden per request.
Rendered version can be found here: openfga/java-sdk#7
References
Close #175
Review Checklist
main