adding stripe modular example #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's also add a readme file as in the rest of the examples |
aaguiarz
requested changes
Sep 10, 2024
| @@ -0,0 +1,34 @@ | |||
| module issuing | |||
There was a problem hiding this comment.
Looks like an odd module name. What would be the app component handling this called? "card-management""
| define view_only: [user] or admin | ||
| define transfer_analyst_in_test_mode: transfer_analyst but not transfer_analyst from test_mode # intermediate relations, just used for evaluating other relations | ||
|
|
||
| define test_mode: [account] # self-defining relationship, used to set a type into a true/false state |
There was a problem hiding this comment.
We should explain in the comments what is test mode used for in Stripe
|
|
||
| extend type account | ||
| relations | ||
| define card: [card] # dual-writes relationships between card & account, when you need to traverse relations on two types checking both ways (starting at card then going up or account then going down) |
There was a problem hiding this comment.
Can you clarify why we need to traverse it both ways?
| ## default spending limit is 500 USD a day | ||
| ## could be 100 USD per transaction | ||
| ## could be 3000 USD per month | ||
| condition spending_limit(transaction_amount: double, transaction_limit: double, daily_amount: double, daily_limit: double, monthly_amount: double, monthly_limit: double) { |
There was a problem hiding this comment.
We should have tuples/tests that use the condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This example models a few of Stripe's core functionality, but not everything.
It introduces another modular models example splitting the model into 3 modules:
accounts.fga- core Stripe account functionalitypayments.fga- (yet to be implemented)issuing.fga- credit card issuing and transactionsIt also introduces modeling concepts such as "self-defining" relationships, "dual-write" relationships, and "intermediate" relationships. It also uses exclusions and conditions.
It includes tests for two scenarios:
Review Checklist
main