Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add confirmation for delete store #92

Merged
merged 2 commits into from
Jul 12, 2023
Merged

feat: add confirmation for delete store #92

merged 2 commits into from
Jul 12, 2023

Conversation

adriantam
Copy link
Member

@adriantam adriantam commented Jul 12, 2023 •
edited by rhamzeh
Loading

Description

Confirmation for delete of store
Screenshot 2023-07-12 at 2 34 57 PM

References

Part of #23

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@adriantam adriantam requested a review from a team as a code owner July 12, 2023 18:38
rhamzeh
rhamzeh requested changes Jul 12, 2023
View reviewed changes
cmd/store/delete.go Outdated Show resolved Hide resolved
cmd/store/delete.go Outdated Show resolved Hide resolved
internal/confirmation/confirmation.go Show resolved Hide resolved
@adriantam adriantam requested a review from rhamzeh July 12, 2023 19:00
@rhamzeh rhamzeh added this pull request to the merge queue Jul 12, 2023
Merged via the queue into main with commit 28af5e9 Jul 12, 2023
@rhamzeh rhamzeh deleted the feat/delete_confirmation branch July 12, 2023 19:13
@Siddhant-K-code Siddhant-K-code mentioned this pull request Oct 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriantam @rhamzeh