Copy over annotations to ingress

[MarcusNoble]

Signed-off-by: Marcus Noble [email protected]

Description

Copy the annotations from FunctionIngress to the Ingress object that gets created so that ingress-specific annotations can be used (for example marking the ingress as being internal)

Motivation and Context

I am currently looking to expose a function within out work network, using an internal ALB but an annotation on the ingress resource is needed for this.

How Has This Been Tested?

Test yaml:

apiVersion: openfaas.com/v1alpha2
kind: FunctionIngress
metadata:
  name: example
  namespace: openfaas
  annotations:
    zalando.org/aws-load-balancer-scheme: internal
spec:
  domain: example.test.com
  function: example
  ingressType: skipper

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Impact to existing users

There shouldn't be any impact.

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have signed-off my commits with git commit -s
• I have added tests to cover my changes.
• All new and existing tests passed.

[derek]

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

[alexellis]

Please could you reset/squash the commits down to remove the merge commit?

That function should be easy to test. I wrote some tests but they don't appear to be in the repo.

Try this: https://blog.alexellis.io/golang-writing-unit-tests/

[alexellis]

Looks in great shape, just a couple of nits for maintenance now, a separate commit will be fine for these changes.

Thanks for adding the unit tests, you didn't resolve, or reply to the comment. That's something you can do to help me.

[derek]

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

[MarcusNoble]

@alexellis Are there any more changes requested for this PR?

[alexellis]

@MarcusNoble should you take specJSON after setting the ingress.class?

[alexellis]

Thank you for picking this up again :)

I have left a comment

[alexellis]

Thank you @MarcusNoble 💪 0.4.0 is now out with the changes.