Warn, instead of exiting on error

[alexellis]

Signed-off-by: Alex Ellis (OpenFaaS Ltd) [email protected]

Description

Warn, instead of exiting on error

Motivation and Context

Fixes: zeerorg/cron-connector#25

How Has This Been Tested?

Testing pending, it should stop the code from hanging when the list functions endpoint returns an error though.

[nitishkumar71]

Did a quick testing for the above MR code. It looks working fine

1. Install faasd

git clone https://github.com/openfaas/faasd --depth=1
cd faasd
./hack/install.sh

2. Login to faasd

sudo cat /var/lib/faasd/secrets/basic-auth-password | faas-cli login -s
faas-cli ls

3. Export Gateway URL and secret path for cron-connector

export gateway_url=http://127.0.0.1:8081
export basic_auth=true
export secret_mount_path=/var/lib/faasd/secrets

4. Add current user to root

sudo usermod -a -G groupname username

5. Build Cron Connector and start

go build --ldflags "-s -w  -X github.com/openfaas/cron-connector/version.GitCommit=${GIT_COMMIT} -X github.com/openfaas/cron-connector/version.Version=${VERSION}" -a -installsuffix cgo -o cron-connector .

sudo -E bash -c './cron-connector'

5. deploy sleep and nodeinfo function from store

faas-cli store deploy sleep --annotation topic=cron-function --annotation schedule="*/1 * * * *"
faas-cli store deploy nodeinfo --annotation schedule="*/5 * * * *" --annotation topic=cron-function

6. Remove nodeinfo function after first run then sleep function. The first time remove command causes failure, a quick second one removes it.

faas-cli remove nodeinfo
faas-cli remove sleep

7. Logs for cron-connector

2022/08/17 22:27:56 Version:    Commit: dev
2022/08/17 22:27:56 Gateway URL: http://127.0.0.1:8080
2022/08/17 22:27:56 Async Invocation: false
2022/08/17 22:27:56 Rebuild interval: 10s       Rebuild timeout: 5s
2022/08/17 22:31:46 Added: nodeinfo.openfaas-fn [*/5 * * * *]
2022/08/17 22:32:26 Added: sleep.openfaas-fn [*/1 * * * *]
2022/08/17 22:33:00 Invoking: sleep.openfaas-fn [*/1 * * * *]
2022/08/17 22:33:02 Response: sleep [200] (2.06s)
2022/08/17 22:34:00 Invoking: sleep.openfaas-fn [*/1 * * * *]
2022/08/17 22:34:02 Response: sleep [200] (2.04s)
2022/08/17 22:35:00 Invoking: nodeinfo.openfaas-fn [*/5 * * * *]
2022/08/17 22:35:00 Invoking: sleep.openfaas-fn [*/1 * * * *]
2022/08/17 22:35:00 Response: nodeinfo [200] (107ms)
2022/08/17 22:35:02 Response: sleep [200] (2.09s)
2022/08/17 22:35:26 Removed: nodeinfo.openfaas-fn [*/5 * * * *]
2022/08/17 22:36:00 Invoking: sleep.openfaas-fn [*/1 * * * *]
2022/08/17 22:36:02 Response: sleep [200] (2.02s)
2022/08/17 22:36:36 error listing functions in openfaas-fn: server returned unexpected status code: 500 - Metrics hander: unexpected status code retrieving functions from backend
2022/08/17 22:36:46 error listing functions in openfaas-fn: server returned unexpected status code: 500 - Metrics hander: unexpected status code retrieving functions from backend
2022/08/17 22:36:56 error listing functions in openfaas-fn: server returned unexpected status code: 500 - Metrics hander: unexpected status code retrieving functions from backend
2022/08/17 22:37:00 Invoking: sleep.openfaas-fn [*/1 * * * *]
2022/08/17 22:37:02 Response: sleep [200] (2.28s)
2022/08/17 22:37:06 error listing functions in openfaas-fn: server returned unexpected status code: 500 - Metrics hander: unexpected status code retrieving functions from backend
2022/08/17 22:37:16 error listing functions in openfaas-fn: server returned unexpected status code: 500 - Metrics hander: unexpected status code retrieving functions from backend
2022/08/17 22:37:26 error listing functions in openfaas-fn: server returned unexpected status code: 500 - Metrics hander: unexpected status code retrieving functions from backend
2022/08/17 22:38:00 Invoking: sleep.openfaas-fn [*/1 * * * *]
2022/08/17 22:38:02 Response: sleep [200] (2.30s)
2022/08/17 22:38:56 Removed: sleep.openfaas-fn [*/1 * * * *]

[alexellis]

Thank you

[alexellis]

I've removed the sleep statements and am merging the fix for a release.