Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENEUROPA-1271: Valueless options are ignored when put into configuration #85

Merged
merged 2 commits into from
Oct 12, 2018

Conversation

pfrenssen
Copy link
Member

No description provided.

@pfrenssen
Copy link
Member Author

Started with a test that proves that the valueless --skip-permissions-setup option is ignored when it is put in a configuration file.

Now I will commit the fix, this should turn the test green.

@pfrenssen pfrenssen reopened this Oct 10, 2018
@pfrenssen
Copy link
Member Author

I had to restart this chain of commits because the composer executable was missing on the test bot, causing unrelated failures. By cleaning out the commit history and restarting it this got auto-closed by Github.

@pfrenssen
Copy link
Member Author

The problem with the missing composer file was still present on the first test run, but only on PHP 7.1. I think this is not a problem for reviewing this PR, since the test still ran successfully on PHP 5.6 and shows the correct error there, so it is proven that the test works correctly:

--- Expected
+++ Actual
@@ @@
-'0555'
+'0775'

/test/task-runner/tests/Commands/DrupalCommandsTest.php:64

The second commit ran successfully and proves that the bug is now fixed.

Copy link
Member

@ademarco ademarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! +1 for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants