OPENEUROPA-1535: Update code-review to master branch. Fix code accord…

…ingly.
openeuropa · Jan 30, 2019 · 6767a62 · 6767a62
1 parent 7840ea8
commit 6767a62
Show file tree

Hide file tree

Showing 38 changed files with 822 additions and 821 deletions.
diff --git a/composer.json b/composer.json
@@ -11,7 +11,7 @@
         "jakeasmith/http_build_url": "^1.0.1"
     },
     "require-dev": {
-        "openeuropa/code-review": "^1.0.0-beta1",
+        "openeuropa/code-review": "dev-master",
         "phpunit/phpunit": "~5.5||~6.0"
     },
     "autoload": {

diff --git a/src/Commands/AbstractCommands.php b/src/Commands/AbstractCommands.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace OpenEuropa\TaskRunner\Commands;
 
 use Consolidation\AnnotatedCommand\AnnotationData;
@@ -15,15 +17,13 @@
 use Symfony\Component\Console\Input\InputInterface;
 
 /**
- * Class AbstractCommands
- *
- * @package OpenEuropa\TaskRunner\Commands
+ * Class AbstractCommands.
  */
 abstract class AbstractCommands implements BuilderAwareInterface, IOAwareInterface, ConfigAwareInterface
 {
     use ConfigAwareTrait;
-    use LoadAllTasks;
     use IO;
+    use LoadAllTasks;
 
     /**
      * Path to YAML configuration file containing command defaults.
@@ -37,18 +37,6 @@ public function getConfigurationFile()
         return __DIR__ . '/../../config/commands/base.yml';
     }
 
-    /**
-     * Command initialization.
-     *
-     * @param \Symfony\Component\Console\Event\ConsoleCommandEvent $event
-     *
-     * @hook pre-command-event *
-     */
-    public function initializeRuntimeConfiguration(ConsoleCommandEvent $event)
-    {
-        Robo::loadConfiguration([$this->getConfigurationFile()], $this->getConfig());
-    }
-
     /**
      * Returns an array of valueless options and their corresponding config key.
      *
@@ -68,6 +56,18 @@ public function getValuelessConfigurationKeys()
         return [];
     }
 
+    /**
+     * Command initialization.
+     *
+     * @param \Symfony\Component\Console\Event\ConsoleCommandEvent $event
+     *
+     * @hook pre-command-event *
+     */
+    public function initializeRuntimeConfiguration(ConsoleCommandEvent $event)
+    {
+        Robo::loadConfiguration([$this->getConfigurationFile()], $this->getConfig());
+    }
+
     /**
      * Initializes valueless options.
      *
@@ -109,9 +109,10 @@ public function initializeValuelessOptions(InputInterface $input, AnnotationData
 
     /**
      * @param  string $name
-     * @return string
      *
      * @throws TaskException
+     *
+     * @return string
      */
     protected function getBin($name)
     {