This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
while working on the platform tests make them non-breaking #9563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @gabreal signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
General-Beck
approved these changes
Sep 14, 2018
5chdn
added
A8-looksgood 🦄
5chdn
approved these changes
Sep 14, 2018
|
I unified the test job names and enabled them all but marked them as fallible. What do you think @gabreal @General-Beck https://gitlab.parity.io/parity/parity-ethereum/pipelines/23623 |
5chdn
added
A0-pleasereview 🤓
ordian
added a commit
to ordian/parity
that referenced
this pull request
Sep 15, 2018
…-fix-windows * 'master' of https://github.com/paritytech/parity: while working on the platform tests make them non-breaking (openethereum#9563) Improve P2P discovery (openethereum#9526) move dockerfile for android build container to scripts repo (openethereum#9560) Simultaneous platform tests WIP (openethereum#9557)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a proposal.
During debugging and potentially upgrading macos hardware pr checks might not be verified at all. So if you get bored by that simply merge it and you can have the previous behaviour (except for the long build times).